TST: Add test of DataFrame.xs() with duplicates (#13719) #22294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @nmusolino! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on August 16, 2018 at 01:14 Hours UTC |
gfyoung
added
Testing
jreback
requested changes
Aug 13, 2018
pandas/tests/test_multilevel.py
Outdated
| @@ -486,6 +486,13 @@ def test_xs_partial(self): | |||
| expected = df.loc['foo', 'one'] | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
| # DataFrame with a MultiIndex containing duplicates (#13719) | |||
There was a problem hiding this comment.
pls add as a separate test.
Codecov Report
@@ Coverage Diff @@
## master #22294 +/- ##
==========================================
- Coverage 92.08% 92.05% -0.04%
==========================================
Files 169 169
Lines 50694 50709 +15
==========================================
- Hits 46682 46678 -4
- Misses 4012 4031 +19
Continue to review full report at Codecov.
|
|
@jreback This is ready for another look. |
jreback
approved these changes
Sep 15, 2018
|
thanks @nmusolino |
aeltanawy
pushed a commit
to aeltanawy/pandas
that referenced
this pull request
Sep 20, 2018
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests of DataFrame.xs() method for multilevel index containing duplicates. The underlying bug reported in #13719 was fixed previously, but was not covered by specific unit tests.
levelkwarg is called. #13719git diff upstream/master -u -- "*.py" | flake8 --diff