CLN/DOC: Refactor timeseries.rst intro and overview #22728
Conversation
|
|
doc/source/timeseries.rst
Outdated
| saturday.day_name() | ||
| # Add 1 business day (Friday --> Monday) | ||
| monday = ts + pd.tseries.offsets.BDay() | ||
| monday.day_name() |
There was a problem hiding this comment.
may be we could rename ts to friday? I think it'd make the example more consistent and easier to understand.
doc/source/timeseries.rst
Outdated
| converted = ts.asfreq('45Min', method='pad') | ||
| converted.head() | ||
| idx = pd.date_range('2018-01-01', periods=72, freq='H') | ||
| ts = pd.Series(np.random.randn(len(idx)), index=idx) |
There was a problem hiding this comment.
I'd prefer range over randn. The data won't also be deterministic, but when you do the mean, it'll be more clear, and the means will increase.
Also, may be it's difficult, but if you can find a resampling example where the original is much smaller than 72, I think it'd help users if we show the original data before showing the transformed data.
doc/source/timeseries.rst
Outdated
| @@ -1443,7 +1486,7 @@ time. The method for this is :meth:`~Series.shift`, which is available on all of | |||
| the pandas objects. | |||
|
|
|||
| .. ipython:: python | |||
|
|
|||
| ts = pd.Series(np.random.randn(len(rng)), index=rng) | |||
There was a problem hiding this comment.
same as before regarding random vs range
doc/source/timeseries.rst
Outdated
| pd.Series(pd.date_range('2000', freq='D', periods=3)) | ||
|
|
||
| :class:`Series` and :class:`DataFrame` have extended data type support and functionality for ``datetime`` and ``timedelta`` | ||
| data when the time data is used as data itself. The other time related concepts will be stored as ``object`` data. |
There was a problem hiding this comment.
I'd name "The other time related concepts", and may be show an example with a datetime Series, so it's easier to see what we exactly mean here.
|
Good suggestions @datapythonista. Incorporated all your comments. |
|
Thanks @datapythonista @WillAyd. |
* CLN/DOC: Refactor timeseries.rst intro and overview * Address review * Forgot missing is
* CLN/DOC: Refactor timeseries.rst intro and overview * Address review * Forgot missing is
Refactoring
timeseries.rstintroduction and overview to give a better introduction into pandas timeseries functionality:NaTin the beginning