-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Fix warnings in doc build #22838
Conversation
(cherry picked from commit 9f0a948)
Warning about elementwise comparison failing when we indexed a dataframe with boolean dataframe (cherry picked from commit 1168273)
(cherry picked from commit 41c8297)
(cherry picked from commit 2e76e84)
(cherry picked from commit a70f86d)
(cherry picked from commit e4a8b06)
(cherry picked from commit ff3d2dd)
(cherry picked from commit e544249)
(cherry picked from commit 8bdb920)
(cherry picked from commit ae0f8ff)
(cherry picked from commit b190866)
(cherry picked from commit a46e4c7)
(cherry picked from commit 74af53d)
(cherry picked from commit 1668c65)
(cherry picked from commit dda2bfc)
Hello @TomAugspurger! Thanks for submitting the PR.
|
Latest commit fixes a failing doctest on master https://travis-ci.org/pandas-dev/pandas/jobs/433544423#L2688
Assuming it's a floating point precision issue. @jorisvandenbossche @datapythonista are you OK with using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great fixes, there are a couple of typos, but looks good.
doc/source/whatsnew/v0.20.0.txt
Outdated
@@ -186,7 +186,7 @@ Previously, only ``gzip`` compression was supported. By default, compression of | |||
URLs and paths are now inferred using their file extensions. Additionally, | |||
support for bz2 compression in the python 2 C-engine improved (:issue:`14874`). | |||
|
|||
.. ipython:: python | |||
.. code-block:::: python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have an extra pair of colons here?
pandas/core/generic.py
Outdated
@@ -2061,9 +2061,10 @@ def to_json(self, path_or_buf=None, orient=None, date_format=None, | |||
|
|||
.. versionadded:: 0.19.0 | |||
compression : {'infer', 'gzip', 'bz2', 'zip', 'xz', None}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we remove the default, the tailing comma is not needed
>>> s.autocorr() # doctest: +ELLIPSIS | ||
0.10355... | ||
>>> s.autocorr(lag=2) # doctest: +ELLIPSIS | ||
-0.99999... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on doctest: +ELLIPSES
Codecov Report
@@ Coverage Diff @@
## master #22838 +/- ##
==========================================
+ Coverage 92.19% 92.19% +<.01%
==========================================
Files 169 169
Lines 50825 50827 +2
==========================================
+ Hits 46857 46860 +3
+ Misses 3968 3967 -1
Continue to review full report at Codecov.
|
Merging in a bit, since master is failing. |
HTTP error downloading conda on that circle-ci one. The others passed, so merging. |
Thanks a lot for this! |
Split from #22743
This has just the docs changes, not the doc build / CI changes, so I don't have to keep fixing merge conflicts.