TST: solve test failure on 32bit systems #22908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @topper-123! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #22908 +/- ##
=======================================
Coverage 92.18% 92.18%
=======================================
Files 169 169
Lines 50830 50830
=======================================
Hits 46860 46860
Misses 3970 3970
Continue to review full report at Codecov.
|
gfyoung
added
Testing
gfyoung
approved these changes
Sep 30, 2018
|
looks fine, but let's fix #22924 first |
|
thanks! |
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff#22296 introduced a test, where
dtype=np.int64was used, butnp.intpis needed for the test to pass on 32bit systems also. This fixes that.After this PR, the pandas test suite passes with no failures on my 32bit python installation on Windows 10.