CLN: Address some TODO comments #23208
Conversation
|
Hello @mroeschke! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #23208 +/- ##
==========================================
+ Coverage 92.19% 92.2% +<.01%
==========================================
Files 169 169
Lines 50950 50943 -7
==========================================
- Hits 46975 46972 -3
+ Misses 3975 3971 -4
Continue to review full report at Codecov.
|
pandas/core/frame.py
Outdated
| @@ -8040,3 +8040,13 @@ def _from_nested_dict(data): | |||
|
|
|||
| def _put_str(s, space): | |||
| return u'{s}'.format(s=s)[:space].ljust(space) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
don't put this here, pandas/core/indexing.py is better or pandas/core/index/api.py
There was a problem hiding this comment.
_get_info_slice is only used once in frame.py and nowhere else. I was thinking we might as well avoid the import.
There was a problem hiding this comment.
ok, can you just inline it then where it is used (make it a local function) instead.
| @@ -3205,7 +3205,7 @@ def is_dtype_instance_mapper(idx, dtype): | |||
| exclude_these.iloc[idx] = not any(map(f, exclude)) | |||
|
|
|||
| dtype_indexer = include_these & exclude_these | |||
| return self.loc[com.get_info_slice(self, dtype_indexer)] | |||
There was a problem hiding this comment.
just move the local function here
|
thanks! |
git diff upstream/master -u -- "*.py" | flake8 --diffI am technically moving some public (non top level) helper functions and making them private, but I don't think it warrants a depreciation.