Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: simplify try_coerce_args #23288

Merged
merged 3 commits into from
Oct 23, 2018

Conversation

jbrockmendel
Copy link
Member

Small simplication available following #23132.

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

@jreback jreback added the Clean label Oct 23, 2018
@jreback jreback added this to the 0.24.0 milestone Oct 23, 2018
@jreback
Copy link
Contributor

jreback commented Oct 23, 2018

looks fine. ping on green.

@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

Merging #23288 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23288      +/-   ##
==========================================
- Coverage   92.22%   92.22%   -0.01%     
==========================================
  Files         169      169              
  Lines       50897    50883      -14     
==========================================
- Hits        46940    46926      -14     
  Misses       3957     3957
Flag Coverage Δ
#multiple 90.64% <100%> (-0.01%) ⬇️
#single 42.29% <76.92%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/internals/blocks.py 94.02% <100%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0c91e...657cc5d. Read the comment docs.

@jbrockmendel
Copy link
Member Author

Ping

@jorisvandenbossche jorisvandenbossche merged commit ff55b32 into pandas-dev:master Oct 23, 2018
@jbrockmendel jbrockmendel deleted the try_coerce branch October 23, 2018 21:46
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants