Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: Remove pd.parser, lib, and tslib #23378

Merged
merged 1 commit into from
Oct 28, 2018
Merged

CLN: Remove pd.parser, lib, and tslib #23378

merged 1 commit into from
Oct 28, 2018

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Oct 27, 2018

Title is self-explanatory.

xref #15537.

@gfyoung gfyoung added Deprecate Functionality to remove in pandas Clean labels Oct 27, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Oct 27, 2018
@pep8speaks
Copy link

Hello @gfyoung! Thanks for submitting the PR.

@gfyoung gfyoung added Datetime Datetime data dtype IO Data IO issues that don't fit into a more specific label labels Oct 27, 2018
@jreback jreback mentioned this pull request Oct 27, 2018
Closed
@gfyoung
Copy link
Member Author

gfyoung commented Oct 27, 2018 •
edited
Loading

https://travis-ci.org/pandas-dev/pandas/jobs/447030560#L2519

xarray=0.8.0 depends on pandas.tslib existing, hence the downstream failure (FYI, xarray is at 0.10.x now, so this is pretty old).

@TomAugspurger : Do you remember why it was pinned in #20767?

Alternatively, because it's a Python 2.x failure, add a skip and move on? 🤷‍♂️

@jreback
Copy link
Contributor

jreback commented Oct 27, 2018

u can bump the xarray test

@gfyoung
Copy link
Member Author

gfyoung commented Oct 27, 2018

u can bump the xarray test

@jreback : To clarify, you mean bump the version number for the xarray dependency?

@jreback
Copy link
Contributor

jreback commented Oct 27, 2018

it’s just the test version
we don’t depend on xarray

@gfyoung
Copy link
Member Author

gfyoung commented Oct 27, 2018 •
edited
Loading

@jreback : Sorry, poor choice of words. I meant to say:

We should just then bump the xarray version for that Travis build (e.g. 0.9.6, when this is fixed).

@gfyoung
CLN: Remove pd.parser, lib, and tslib
86e439e 
xref pandas-devgh-15537.

Need to bumpy xarray version for
Travis 2.7 because 0.8.0 becomes
incompatible with this change.
@codecov
Copy link

codecov bot commented Oct 27, 2018 •
edited
Loading

Codecov Report

Merging #23378 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23378      +/-   ##
==========================================
- Coverage   92.22%   92.17%   -0.06%     
==========================================
  Files         169      166       -3     
  Lines       51261    51250      -11     
==========================================
- Hits        47277    47238      -39     
- Misses       3984     4012      +28
Flag Coverage Δ
#multiple 90.6% <ø> (-0.06%) ⬇️
#single 42.21% <ø> (-0.03%) ⬇️
Impacted Files Coverage Δ
pandas/util/_depr_module.py 0% <0%> (-65.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 051f4a2...86e439e. Read the comment docs.

@jreback jreback merged commit 8d27d46 into pandas-dev:master Oct 28, 2018
@jreback
Copy link
Contributor

jreback commented Oct 28, 2018

nice, thanks!

@gfyoung gfyoung deleted the parser-lib-tslib-remove branch October 28, 2018 05:19
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@gfyoung @tm9k1
CLN: Remove pd.parser, lib, and tslib (pandas-dev#23378)
1c9f993 
xref pandas-devgh-15537.

Need to bumpy xarray version for
Travis 2.7 because 0.8.0 becomes
incompatible with this change.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung @Pingviinituutti
CLN: Remove pd.parser, lib, and tslib (pandas-dev#23378)
2d53e7d 
xref pandas-devgh-15537.

Need to bumpy xarray version for
Travis 2.7 because 0.8.0 becomes
incompatible with this change.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung @Pingviinituutti
CLN: Remove pd.parser, lib, and tslib (pandas-dev#23378)
18aee44 
xref pandas-devgh-15537.

Need to bumpy xarray version for
Travis 2.7 because 0.8.0 becomes
incompatible with this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Clean Datetime Datetime data dtype Deprecate Functionality to remove in pandas IO Data IO issues that don't fit into a more specific label
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gfyoung @pep8speaks @jreback