MAINT: tm.assert_raises_regex --> pytest.raises #23592

gfyoung · 2018-11-09T09:35:09Z

pytest.raises has all of the functionality that we need from tm.assert_raises_regex.

Closes #16521 (for good this time! 🙂 ).

If this is something we would like to have for 0.24.0, I would ask that this get reviewed and merged ASAP, given how massive the refactoring is and the high probability of merge conflicts.

cc @pandas-dev/pandas-core

codecov · 2018-11-09T10:58:50Z

Codecov Report

Merging #23592 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #23592      +/-   ##
==========================================
- Coverage   92.25%   92.24%   -0.02%     
==========================================
  Files         161      161              
  Lines       51277    51278       +1     
==========================================
- Hits        47305    47299       -6     
- Misses       3972     3979       +7

Flag	Coverage Δ
#multiple	`90.62% <100%> (-0.02%)`	⬇️
#single	`42.28% <0%> (-0.04%)`	⬇️

Impacted Files	Coverage Δ
pandas/util/testing.py	`86.05% <100%> (-0.66%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ed92ef...2b7fb24. Read the comment docs.

datapythonista

Really nice work. My browser had problems to load the whole diff, so I guess this kept you entertained for a while... ;)

Looks really good, there are just few things I don't understand.

pandas/tests/io/test_pytables.py

pandas/tests/test_algos.py

pandas/tests/test_strings.py

pandas/tests/frame/test_alter_axes.py

pandas/tests/io/parser/c_parser_only.py

jreback · 2018-11-09T12:46:46Z

@gfyoung wasn't expecting all of these in a single PR. ok though.

jreback · 2018-11-09T12:47:42Z

can you deprecate tm.assert_raises_regex as well. and update the docs.

jreback · 2018-11-09T12:47:47Z

ping when ready

jorisvandenbossche · 2018-11-09T12:52:15Z

can you deprecate tm.assert_raises_regex as well. and update the docs.

Let's do that in a separate PR? This diff is already huge to check

jreback · 2018-11-09T12:54:49Z

Let's do that in a separate PR? This diff is already huge to check

yes this is ok

datapythonista · 2018-11-09T13:47:48Z

assert_raises_regex is removed in this PR, I think it's the last file, you need to expand the diff, as it's collapsed because of the size.

jorisvandenbossche · 2018-11-09T13:52:18Z

Then let's add it back here, if we want to deprecate it (which I think is a good idea)

gfyoung · 2018-11-09T18:00:24Z

@jreback @jorisvandenbossche :

Why are we deprecating? It's not even part of the public testing API (in pandas/testing). There are no docs to update in the first place.

assert_raises_regex is essentially our internal implementation for doing what pytest.raises does now.
@datapythonista identified several places for refactorings and improvements, but I would like to save those for a follow-up. From the viewpoint of infrastructure, this is ready to merge.

jreback · 2018-11-10T00:54:05Z

the reason to deprecate is that it’s in our public ish testing interface and has been around for a while - we can just remove in the next version (short deprecation cycle)
this is a little more friendly

gfyoung · 2018-11-10T00:58:42Z

the reason to deprecate is that it’s in our public ish testing interface and has been around for a while - we can just remove in the next version (short deprecation cycle)

@jreback : Okay, that's fair. I'll deprecate this then and have it removed in the next major release (either 0.25 or 1.0, given that this is not totally public, only "public-ish" 🙂 ).

pytest.raises has all of the functionality that we need from tm.assert_raises_regex. Closes pandas-devgh-16521.

gfyoung · 2018-11-10T22:07:36Z

@jreback @datapythonista : Addressed all comments, and all is still green. PTAL.

datapythonista

lgtm, thanks @gfyoung

jreback · 2018-11-10T22:13:44Z

thanks!

…fixed * upstream/master: DOC: Fixes to docstring to add validation to CI (pandas-dev#23560) DOC: Remove incorrect periods at the end of parameter types (pandas-dev#23600) MAINT: tm.assert_raises_regex --> pytest.raises (pandas-dev#23592) DOC: Updating Series.resample and DataFrame.resample docstrings (pandas-dev#23197) ENH: Support for partition_cols in to_parquet (pandas-dev#23321) TST: Use intp as expected dtype in IntervalIndex indexing tests (pandas-dev#23609)

* upstream/master: BUG: Casting tz-aware DatetimeIndex to object-dtype ndarray/Index (pandas-dev#23524) BUG: Delegate more of Excel parsing to CSV (pandas-dev#23544) API: DataFrame.__getitem__ returns Series for sparse column (pandas-dev#23561) CLN: use float64_t consistently instead of double, double_t (pandas-dev#23583) DOC: Fix Order of parameters in docstrings (pandas-dev#23611) TST: Unskip some Categorical Tests (pandas-dev#23613) TST: Fix integer ops comparison test (pandas-dev#23619) DOC: Fixes to docstring to add validation to CI (pandas-dev#23560) DOC: Remove incorrect periods at the end of parameter types (pandas-dev#23600) MAINT: tm.assert_raises_regex --> pytest.raises (pandas-dev#23592) DOC: Updating Series.resample and DataFrame.resample docstrings (pandas-dev#23197)

jreback · 2018-11-11T19:09:13Z

didn’t check but do we fail an internal build if assert_raises_regex is used?

sure it would raise a FutureWarning but that doesn’t always fail it i think

TomAugspurger · 2018-11-11T19:17:33Z

The numpydev job will fail if we use it in a test that is run, but that doesn't have all the optional dependencies so some tests are skipped.

…

On Sun, Nov 11, 2018 at 1:09 PM Jeff Reback ***@***.***> wrote: didn’t check but do we fail an internal build if assert_raises_regex is used? sure it would raise a FutureWarning but that doesn’t always fail it i think — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#23592 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIoM8fzT1P-JT--yvCcI9L5WQAksEks5uuHXdgaJpZM4YWP16> .

jreback · 2018-11-11T19:20:11Z

ok @gfyoung can u add to the code_checks then to look for this (we already do for things like np.testing)

gfyoung · 2018-11-11T19:46:44Z

@jreback @TomAugspurger : I grepped the entire codebase, and the only instances of assert_raises_regex are in testing.py and test_testing.py.

The warnings should cause the numpydev build to fail if it were to happen (which it doesn't).

datapythonista · 2018-11-11T20:00:54Z

I think the idea is not on what we have now, but in case someone creates a new PR that uses assert_raises_regex. I can add the check, so we show the CI in red if that's the case. Will send a PR with it shortly.

datapythonista · 2018-11-11T20:19:20Z

Opened #23627 with the check.

Follow-up to gh-23592.

* MAINT: tm.assert_raises_regex --> pytest.raises pytest.raises has all of the functionality that we need from tm.assert_raises_regex. Closes pandas-devgh-16521. * Don't remove, just deprecate assert_raises_regex * CLN: Test cleanups and follow-ups

…s-dev#23627) Follow-up to pandas-devgh-23592.

* MAINT: tm.assert_raises_regex --> pytest.raises pytest.raises has all of the functionality that we need from tm.assert_raises_regex. Closes pandas-devgh-16521. * Don't remove, just deprecate assert_raises_regex * CLN: Test cleanups and follow-ups

…s-dev#23627) Follow-up to pandas-devgh-23592.

* MAINT: tm.assert_raises_regex --> pytest.raises pytest.raises has all of the functionality that we need from tm.assert_raises_regex. Closes pandas-devgh-16521. * Don't remove, just deprecate assert_raises_regex * CLN: Test cleanups and follow-ups

…s-dev#23627) Follow-up to pandas-devgh-23592.

* MAINT: tm.assert_raises_regex --> pytest.raises pytest.raises has all of the functionality that we need from tm.assert_raises_regex. Closes pandas-devgh-16521. * Don't remove, just deprecate assert_raises_regex * CLN: Test cleanups and follow-ups

…s-dev#23627) Follow-up to pandas-devgh-23592.

gfyoung added Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite Clean labels Nov 9, 2018

gfyoung mentioned this pull request Nov 9, 2018

TST: pytest.raises vs. tm.assert_raises_regex #16521

Closed

gfyoung force-pushed the assert-raises-regex-remove branch from 261ec39 to 81e7c42 Compare November 9, 2018 10:18

datapythonista reviewed Nov 9, 2018

View reviewed changes

jreback added this to the 0.24.0 milestone Nov 9, 2018

gfyoung force-pushed the assert-raises-regex-remove branch 2 times, most recently from f0cfe1c to 325adea Compare November 10, 2018 12:07

gfyoung added 3 commits November 10, 2018 10:18

MAINT: tm.assert_raises_regex --> pytest.raises

da8ab9b

pytest.raises has all of the functionality that we need from tm.assert_raises_regex. Closes pandas-devgh-16521.

Don't remove, just deprecate assert_raises_regex

d18e14c

CLN: Test cleanups and follow-ups

2b7fb24

gfyoung force-pushed the assert-raises-regex-remove branch from 325adea to 2b7fb24 Compare November 10, 2018 18:23

datapythonista approved these changes Nov 10, 2018

View reviewed changes

jreback merged commit 383d052 into pandas-dev:master Nov 10, 2018

gfyoung deleted the assert-raises-regex-remove branch November 10, 2018 23:22

jsexauer mentioned this pull request Nov 10, 2018

DEPR: Clean up list of deprecations from prior versions #6581

Closed

1 task

datapythonista mentioned this pull request Nov 11, 2018

CI: Check in the CI that assert_raises_regex is not being used #23627

Merged

gfyoung pushed a commit that referenced this pull request Nov 12, 2018

CI: Check in the CI that assert_raises_regex is not being used (#23627)

a092e91

Follow-up to gh-23592.

JustinZhengBC pushed a commit to JustinZhengBC/pandas that referenced this pull request Nov 14, 2018

CI: Check in the CI that assert_raises_regex is not being used (panda…

d4be020

…s-dev#23627) Follow-up to pandas-devgh-23592.

tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018

CI: Check in the CI that assert_raises_regex is not being used (panda…

2b692a0

…s-dev#23627) Follow-up to pandas-devgh-23592.

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

CI: Check in the CI that assert_raises_regex is not being used (panda…

796d505

…s-dev#23627) Follow-up to pandas-devgh-23592.

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

CI: Check in the CI that assert_raises_regex is not being used (panda…

300946d

…s-dev#23627) Follow-up to pandas-devgh-23592.

jreback mentioned this pull request Nov 20, 2019

DEPR: deprecations log for removed issues #13777

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MAINT: tm.assert_raises_regex --> pytest.raises #23592

MAINT: tm.assert_raises_regex --> pytest.raises #23592

gfyoung commented Nov 9, 2018 •

edited

Loading

codecov bot commented Nov 9, 2018 •

edited

Loading

datapythonista left a comment

jreback commented Nov 9, 2018

jreback commented Nov 9, 2018

jreback commented Nov 9, 2018

jorisvandenbossche commented Nov 9, 2018

jreback commented Nov 9, 2018

datapythonista commented Nov 9, 2018

jorisvandenbossche commented Nov 9, 2018

gfyoung commented Nov 9, 2018 •

edited

Loading

jreback commented Nov 10, 2018

gfyoung commented Nov 10, 2018 •

edited

Loading

gfyoung commented Nov 10, 2018

datapythonista left a comment

jreback commented Nov 10, 2018

jreback commented Nov 11, 2018

TomAugspurger commented Nov 11, 2018 via email

jreback commented Nov 11, 2018

gfyoung commented Nov 11, 2018 •

edited

Loading

datapythonista commented Nov 11, 2018

datapythonista commented Nov 11, 2018

MAINT: tm.assert_raises_regex --> pytest.raises #23592

MAINT: tm.assert_raises_regex --> pytest.raises #23592

Conversation

gfyoung commented Nov 9, 2018 • edited Loading

codecov bot commented Nov 9, 2018 • edited Loading

Codecov Report

datapythonista left a comment

Choose a reason for hiding this comment

jreback commented Nov 9, 2018

jreback commented Nov 9, 2018

jreback commented Nov 9, 2018

jorisvandenbossche commented Nov 9, 2018

jreback commented Nov 9, 2018

datapythonista commented Nov 9, 2018

jorisvandenbossche commented Nov 9, 2018

gfyoung commented Nov 9, 2018 • edited Loading

jreback commented Nov 10, 2018

gfyoung commented Nov 10, 2018 • edited Loading

gfyoung commented Nov 10, 2018

datapythonista left a comment

Choose a reason for hiding this comment

jreback commented Nov 10, 2018

jreback commented Nov 11, 2018

TomAugspurger commented Nov 11, 2018 via email

jreback commented Nov 11, 2018

gfyoung commented Nov 11, 2018 • edited Loading

datapythonista commented Nov 11, 2018

datapythonista commented Nov 11, 2018

gfyoung commented Nov 9, 2018 •

edited

Loading

codecov bot commented Nov 9, 2018 •

edited

Loading

gfyoung commented Nov 9, 2018 •

edited

Loading

gfyoung commented Nov 10, 2018 •

edited

Loading

gfyoung commented Nov 11, 2018 •

edited

Loading