Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: Deprecating .clip_lower and .clip_upper #24203

Merged
merged 4 commits into from
Dec 10, 2018
Merged

DEPR: Deprecating .clip_lower and .clip_upper #24203

merged 4 commits into from
Dec 10, 2018

Conversation

datapythonista
Copy link
Member

@datapythonista datapythonista added the Deprecate Functionality to remove in pandas label Dec 10, 2018
@pep8speaks
Copy link

Hello @datapythonista! Thanks for submitting the PR.

@jreback jreback mentioned this pull request Dec 10, 2018
Closed
34 tasks
@codecov
Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #24203 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24203      +/-   ##
==========================================
- Coverage   92.21%   92.21%   -0.01%     
==========================================
  Files         162      162              
  Lines       51723    51725       +2     
==========================================
+ Hits        47695    47696       +1     
- Misses       4028     4029       +1
Flag Coverage Δ
#multiple 90.61% <100%> (ø) ⬆️
#single 43.03% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 96.65% <100%> (ø) ⬆️
pandas/io/json/json.py 92.61% <0%> (-0.48%) ⬇️
pandas/util/testing.py 87.51% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 138a59a...5d0d01a. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 10, 2018 •
edited
Loading

Codecov Report

Merging #24203 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24203      +/-   ##
==========================================
+ Coverage   92.21%   92.21%   +<.01%     
==========================================
  Files         162      162              
  Lines       51761    51763       +2     
==========================================
+ Hits        47731    47733       +2     
  Misses       4030     4030
Flag Coverage Δ
#multiple 90.61% <100%> (ø) ⬆️
#single 43% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 96.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5389987...383f6d6. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Dec 10, 2018
jreback
jreback approved these changes Dec 10, 2018
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine. one small comment. pls add to #6581 as well

doc/source/whatsnew/v0.24.0.rst Outdated
@@ -1113,6 +1113,8 @@ Deprecations
- :func:`pandas.types.is_datetimetz` is deprecated in favor of `pandas.types.is_datetime64tz` (:issue:`23917`)
- Creating a :class:`TimedeltaIndex` or :class:`DatetimeIndex` by passing range arguments `start`, `end`, and `periods` is deprecated in favor of :func:`timedelta_range` and :func:`date_range` (:issue:`23919`)
- Passing a string alias like ``'datetime64[ns, UTC]'`` as the `unit` parameter to :class:`DatetimeTZDtype` is deprecated. Use :class:`DatetimeTZDtype.construct_from_string` instead (:issue:`23990`).
- :meth:`Series.clip_lower`, :meth:`Series.clip_upper`, :meth:`DataFrame.clip_lower` and :meth:`DataFrame.clip_upper` are deprecated and will be removed in a future version.
Use ``Series.clip(lower=threshold)``, ``Series.clip(upper=threshold)`` and the equivalent ``DataFrame`` methods (:issue:`24203`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this on another line?

@jreback
Copy link
Contributor

jreback commented Dec 10, 2018

and pls merge master

@jsexauer jsexauer mentioned this pull request Dec 10, 2018
Closed
1 task
@jreback
Copy link
Contributor

jreback commented Dec 10, 2018

lgtm. merge on green.

@datapythonista datapythonista merged commit a771b47 into pandas-dev:master Dec 10, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@datapythonista @Pingviinituutti
DEPR: Deprecating .clip_lower and .clip_upper (pandas-dev#24203)
08be4c6
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@datapythonista @Pingviinituutti
DEPR: Deprecating .clip_lower and .clip_upper (pandas-dev#24203)
7e192de
@jreback jreback mentioned this pull request Nov 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@datapythonista @pep8speaks @jreback @jorisvandenbossche