CategoricalAccessor.categorical removed in 0.24.0rc1 #24751 #24754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jan 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #24754 +/- ##
===========================================
- Coverage 92.38% 42.91% -49.47%
===========================================
Files 166 166
Lines 52363 52370 +7
===========================================
- Hits 48376 22476 -25900
- Misses 3987 29894 +25907
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24754 +/- ##
==========================================
+ Coverage 92.38% 92.38% +<.01%
==========================================
Files 166 166
Lines 52366 52375 +9
==========================================
+ Hits 48380 48389 +9
Misses 3986 3986
Continue to review full report at Codecov.
|
|
Given @jreback's suggestion that this is unnecessary, I will close this. |
benjaminr
restored the
depr/CategoricalAccessor-categorical-name-index
branch
|
You'll also need to update uses of |
…oricalAccessor-categorical-name-index
|
Hello @benjaminr! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on January 15, 2019 at 20:23 Hours UTC |
TomAugspurger
added
Categorical
|
Just a comment.
…On Tue, Jan 15, 2019 at 11:39 AM Benjamin Rowell ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pandas/tests/series/test_api.py
<#24754 (comment)>:
> @@ -245,10 +245,11 @@ def test_tab_completion(self):
def test_tab_completion_with_categorical(self):
# test the tab completion display
- ok_for_cat = ['categories', 'codes', 'ordered', 'set_categories',
Ah no worries.
When you say note on that property, is a comment sufficient, or do you
mean in the deprecation FutureWarning message?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#24754 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIgk_z0azVQ6WA6hqa68nOy2MQkBGks5vDhJBgaJpZM4Z9XZr>
.
|
benjaminr
force-pushed
the
depr/CategoricalAccessor-categorical-name-index
branch
from
961082c
to
9a0c381
Compare
jreback
approved these changes
Jan 15, 2019
|
Thanks @benjaminr! |
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
…#24751 (pandas-dev#24754) * Implementation for CategoricalAccessor.categorical removed in 0.24.0rc1 pandas-dev#24751
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
…#24751 (pandas-dev#24754) * Implementation for CategoricalAccessor.categorical removed in 0.24.0rc1 pandas-dev#24751
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff