option callback on value change, use an option to control use_inf_as_null #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
@wesm , just want to make sure this and the other 0.10 PR's won't get left behind, |
ghost
mentioned this pull request
|
don't worry, i'll definitely give fair warning before cutting 0.10 final... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not married to the "mode.X" option key, but be aware that the dynamic generated
docstrings for the options API favour a small number of top level keys with multiple keys
under them and so i consolidated
test.interactiveintomode.sim_interactive.Some sane taxonomy needs to be established early on to keep things tidy,
Be an option-naming fascist I say.
http://martinfowler.com/bliki/TwoHardThings.html
related: #1919