CLN: isort from attrs_caching.py to eval.py #25060
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25060 +/- ##
=======================================
Coverage 92.37% 92.37%
=======================================
Files 166 166
Lines 52403 52403
=======================================
Hits 48405 48405
Misses 3998 3998
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #25060 +/- ##
=======================================
Coverage 91.26% 91.26%
=======================================
Files 173 173
Lines 52968 52968
=======================================
Hits 48339 48339
Misses 4629 4629
Continue to review full report at Codecov.
|
|
The error I'm getting is |
|
IIRC the benchmarks are only checked when those files are touched. It's
possible that a recent commit broke one of the benchmarks.
I'd recommend finding the previous commit to touch the benchmarks files,
and seeing if any of the commits between that and master broke them.
…On Thu, Jan 31, 2019 at 4:01 PM Andrew Gaspari ***@***.***> wrote:
The error I'm getting is ##[error]Benchmarks run with errors in the
Checks_and_doc Job > Running benchmarks test. I solved one failing test
from the last commit by returning the asv_bench/benchmarks/dtypes.py to
what it was before I ran isort. I imagine something similar went wrong this
time, but looking through the diffs and the output, I'm not sure where to
start looking. Any ideas?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#25060 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIomjsZ6O0lDjJjSLhZv4aJAT4xl3ks5vI2e6gaJpZM4adF5->
.
|
|
@gasparia405 can you merge master? IIRC had a recent PR to fix issue with benchmark tests |
|
@WillAyd Thanks for the heads up. I've merged with master and tests passing! |
| @@ -34,4 +36,4 @@ def time_cache_readonly(self): | |||
| self.obj.prop | |||
|
|
|||
|
|
|||
| from .pandas_vb_common import setup # noqa: F401 | |||
| from .pandas_vb_common import setup # noqa: F401 isort:skip | |||
There was a problem hiding this comment.
IIRC from other PRs this was moved to the bottom of the benchmark instead of adding the skip. Would rather do the same here
There was a problem hiding this comment.
I had this issue in #24958 where the linting fails if isort:skip isn't included. I'm looking into the other errors now and it looks like two of the benchmarks failed.
|
Hmm the benchmark failures might be related to work done in #25517 |
|
@gasparia405 can you merge master? |
|
Closing as stale ping if you'd like to pick this back up |
git diff upstream/master -u -- "*.py" | flake8 --diffMore updates from issue #23334: