Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed geo accessor example in extending.rst #25420

Merged
merged 2 commits into from
Feb 25, 2019
Merged

fixed geo accessor example in extending.rst #25420

merged 2 commits into from
Feb 25, 2019

Commits on Feb 23, 2019

  1. the method _validate for the geo accessor example now checks presence… 

    … of substring 'lat' and 'lon' in each column

The previous code was incompatible with the following paragraph.

("Now users can access your methods using the ``geo`` namespace"...)
    @ThibTrip
    ThibTrip committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    120c84c View commit details
    Browse the repository at this point in the history

  2. updated issue with "lat" and "lon" in _validate for the geo accessor … 

    …in extending.rst

After reading a comment from TomAugspurger I realised "lon" and "lat" had just been switched with "longitude" and "latitude" in the following code block. So I used those names here as well.
    @ThibTrip
    ThibTrip committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    a7b602e View commit details
    Browse the repository at this point in the history