Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Check pytables<3.5.1 when skipping #25773

Merged
merged 2 commits into from
Mar 19, 2019
Merged

TST: Check pytables<3.5.1 when skipping #25773

merged 2 commits into from
Mar 19, 2019

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Mar 19, 2019 •
edited
Loading

3.5.1 was made available on conda, causing xfail_non_writeable tests to fail.

Note that this is just to get master to pass again (started failing when #25751 was merged).

This new release of pytables, however, brings up the question of how we want to proceed with #24839, as it appears that all of our CI builds that install pytables will use this version now.

It seems a little early to declare that 3.5.1 is our minimum version, but it definitely looks like we could drop this xfail from our tests at some point in the near future.

@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Dependencies Required and optional dependencies labels Mar 19, 2019
@gfyoung gfyoung added this to the 0.25.0 milestone Mar 19, 2019
@gfyoung gfyoung added the CI Continuous Integration label Mar 19, 2019
@gfyoung
Copy link
Member Author

gfyoung commented Mar 19, 2019 •
edited
Loading

Really strange geopandas failure here. Doesn't seem related to my PR though...

I also see no changes in the geopandas and fiona versions. Any ideas?

@simonjayhawkins
Copy link
Member

Any ideas?

@gfyoung : there was a ResourceWarning: unclosed <ssl.SSLSocket [closed] fd=180, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6> ealier in the logs. could this have messed things up. maybe worth restarting the job.

@jorisvandenbossche
Copy link
Member

Really strange geopandas failure here. Doesn't seem related to my PR though...

That's indeed not related. It is a failure with one of the dependencies. It might well be it is only temporary (eg when they are updating packages on conda-forge, there might be a moment not yet everything is matching with each other). But if it keeps failing, we can skip it for now.

@gfyoung
Copy link
Member Author

gfyoung commented Mar 19, 2019

But if it keeps failing, we can skip it for now.

@jorisvandenbossche : Sounds good. I'll restart again tomorrow.

@jorisvandenbossche
Copy link
Member

Just restarted the build now

@jreback
Copy link
Contributor

jreback commented Mar 19, 2019

@gfyoung you can just put a skip around geopandas for now (or pin to a prior version)

@jorisvandenbossche
Copy link
Member

@jreback see #25778 for the geopandas issue. Skipping here is fine, I can fix it later in a separate PR.

@jreback
Copy link
Contributor

jreback commented Mar 19, 2019

we shouldn't block on installation issues of another library here.

@gfyoung
TST: Check pytables<3.5.1 when skipping
2923030 
3.5.1 was made available on conda, causing
'xfail_non_writeable' tests to fail.
@gfyoung
TST: Skip geopandas downstream test
9d61a0b 
xref pandas-devgh-25778
@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@c8ba766). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #25773   +/-   ##
=========================================
  Coverage          ?   41.76%           
=========================================
  Files             ?      172           
  Lines             ?    52965           
  Branches          ?        0           
=========================================
  Hits              ?    22122           
  Misses            ?    30843           
  Partials          ?        0
Flag Coverage Δ
#single 41.76% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ba766...9d61a0b. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 19, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@c8ba766). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #25773   +/-   ##
=========================================
  Coverage          ?   91.26%           
=========================================
  Files             ?      172           
  Lines             ?    52965           
  Branches          ?        0           
=========================================
  Hits              ?    48338           
  Misses            ?     4627           
  Partials          ?        0
Flag Coverage Δ
#multiple 89.82% <ø> (?)
#single 41.74% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ba766...9d61a0b. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Mar 19, 2019

lgtm. ping on green.

@jreback jreback merged commit c975fc4 into pandas-dev:master Mar 19, 2019
@jreback
Copy link
Contributor

jreback commented Mar 19, 2019

thanks @gfyoung

@gfyoung gfyoung deleted the pytables-xfail-update branch March 19, 2019 18:54
sighingnow added a commit to sighingnow/pandas that referenced this pull request Mar 20, 2019
@sighingnow
Merge remote-tracking branch 'origin/master' into fix-25557
bce25c9 
* origin/master:
  DOC: clean bug fix section in whatsnew (pandas-dev#25792)
  DOC: Fixed PeriodArray api ref (pandas-dev#25526)
  Move locale code out of tm, into _config (pandas-dev#25757)
  Unpin pycodestyle (pandas-dev#25789)
  Add test for rdivmod on EA array (GH23287) (pandas-dev#24047)
  ENH: Support datetime.timezone objects (pandas-dev#25065)
  Cython language level 3 (pandas-dev#24538)
  API: concat on sparse values (pandas-dev#25719)
  TST: assert_produces_warning works with filterwarnings (pandas-dev#25721)
  make core.config self-contained (pandas-dev#25613)
  CLN: replace %s syntax with .format in pandas.io.parsers (pandas-dev#24721)
  TST: Check pytables<3.5.1 when skipping (pandas-dev#25773)
  DOC: Fix typo in docstring of DataFrame.memory_usage  (pandas-dev#25770)
  Replace dicts with OrderedDicts in groupby aggregation functions (pandas-dev#25693)
  TST: Fixturize tests/frame/test_missing.py (pandas-dev#25640)
  DOC: Improve the docsting of Series.iteritems (pandas-dev#24879)
  DOC: Fix function name. (pandas-dev#25751)
  Implementing iso_week_year support for to_datetime (pandas-dev#25541)
  DOC: clarify corr behaviour when using a callable (pandas-dev#25732)
  remove unnecessary check_output (pandas-dev#25755)

# Conflicts:
#	doc/source/whatsnew/v0.25.0.rst
thoo added a commit to thoo/pandas that referenced this pull request Mar 20, 2019
@thoo
Merge remote-tracking branch 'upstream/master' into pivot
a4e8d38 
* upstream/master: (55 commits)
  PERF: Improve performance of StataReader (pandas-dev#25780)
  Speed up tokenizing of a row in csv and xstrtod parsing (pandas-dev#25784)
  BUG: Fix _binop for operators for serials which has more than one returns (divmod/rdivmod). (pandas-dev#25588)
  BUG-24971 copying blocks also considers ndim (pandas-dev#25521)
  CLN: Panel reference from documentation (pandas-dev#25649)
  ENH: Quoting column names containing spaces with backticks to use them in query and eval. (pandas-dev#24955)
  BUG: reading windows utf8 filenames in py3.6 (pandas-dev#25769)
  DOC: clean bug fix section in whatsnew (pandas-dev#25792)
  DOC: Fixed PeriodArray api ref (pandas-dev#25526)
  Move locale code out of tm, into _config (pandas-dev#25757)
  Unpin pycodestyle (pandas-dev#25789)
  Add test for rdivmod on EA array (GH23287) (pandas-dev#24047)
  ENH: Support datetime.timezone objects (pandas-dev#25065)
  Cython language level 3 (pandas-dev#24538)
  API: concat on sparse values (pandas-dev#25719)
  TST: assert_produces_warning works with filterwarnings (pandas-dev#25721)
  make core.config self-contained (pandas-dev#25613)
  CLN: replace %s syntax with .format in pandas.io.parsers (pandas-dev#24721)
  TST: Check pytables<3.5.1 when skipping (pandas-dev#25773)
  DOC: Fix typo in docstring of DataFrame.memory_usage  (pandas-dev#25770)
  ...
anmyachev pushed a commit to anmyachev/pandas that referenced this pull request Apr 24, 2019
@gfyoung @anmyachev
TST: Check pytables<3.5.1 when skipping (pandas-dev#25773)
b64de08 
* TST: Check pytables<3.5.1 when skipping

3.5.1 was made available on conda, causing
'xfail_non_writeable' tests to fail.

* TST: Skip geopandas downstream test

xref pandas-devgh-25778
anmyachev added a commit to anmyachev/pandas that referenced this pull request Apr 24, 2019
@anmyachev
fix CI build errors:
874db41 
TST: Check pytables<3.5.1 when skipping (pandas-dev#25773)

* TST: Check pytables<3.5.1 when skipping

3.5.1 was made available on conda, causing
'xfail_non_writeable' tests to fail.

* TST: Skip geopandas downstream test

xref pandas-devgh-25778

added 'except NULL' for get_c_string_buf_and_size in util.pxd(bug without)

fixed lint error

Fixed code issue from compat with new numpydoc (pandas-dev#26188)

fixed docstring
anmyachev added a commit to anmyachev/pandas that referenced this pull request Apr 25, 2019
@anmyachev
fix CI build errors:
1e6b4d9 
TST: Check pytables<3.5.1 when skipping (pandas-dev#25773)

* TST: Check pytables<3.5.1 when skipping

3.5.1 was made available on conda, causing
'xfail_non_writeable' tests to fail.

* TST: Skip geopandas downstream test

xref pandas-devgh-25778

added 'except NULL' for get_c_string_buf_and_size in util.pxd(bug without)

fixed lint error

Fixed code issue from compat with new numpydoc (pandas-dev#26188)

fixed docstring
anmyachev added a commit to anmyachev/pandas that referenced this pull request Apr 25, 2019
@anmyachev
fix CI build errors:
ef97ec3 
TST: Check pytables<3.5.1 when skipping (pandas-dev#25773)

* TST: Check pytables<3.5.1 when skipping

3.5.1 was made available on conda, causing
'xfail_non_writeable' tests to fail.

* TST: Skip geopandas downstream test

xref pandas-devgh-25778

added 'except NULL' for get_c_string_buf_and_size in util.pxd(bug without)

fixed lint error

Fixed code issue from compat with new numpydoc (pandas-dev#26188)

fixed docstring
anmyachev added a commit to anmyachev/pandas that referenced this pull request Apr 25, 2019
@anmyachev
fix CI build errors:
b750483 
TST: Check pytables<3.5.1 when skipping (pandas-dev#25773)

* TST: Check pytables<3.5.1 when skipping

3.5.1 was made available on conda, causing
'xfail_non_writeable' tests to fail.

* TST: Skip geopandas downstream test

xref pandas-devgh-25778

added 'except NULL' for get_c_string_buf_and_size in util.pxd(bug without)

fixed lint error

Fixed code issue from compat with new numpydoc (pandas-dev#26188)

fixed docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Continuous Integration Dependencies Required and optional dependencies Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gfyoung @simonjayhawkins @jorisvandenbossche @jreback