Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Remove deprecated parse_cols from read_excel #26522

Merged
merged 1 commit into from
May 25, 2019

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke added Clean IO Excel read_excel, to_excel labels May 25, 2019
@mroeschke mroeschke added this to the 0.25.0 milestone May 25, 2019
@codecov
Copy link

codecov bot commented May 25, 2019

Codecov Report

Merging #26522 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26522      +/-   ##
==========================================
- Coverage   91.75%   91.75%   -0.01%     
==========================================
  Files         174      174              
  Lines       50665    50664       -1     
==========================================
- Hits        46489    46485       -4     
- Misses       4176     4179       +3
Flag Coverage Δ
#multiple 90.26% <100%> (-0.01%) ⬇️
#single 41.73% <0%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/excel/_base.py 91.81% <100%> (-0.04%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.7% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba48fc4...8f619dd. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 25, 2019

Codecov Report

Merging #26522 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26522      +/-   ##
==========================================
- Coverage   91.75%   91.75%   -0.01%     
==========================================
  Files         174      174              
  Lines       50665    50664       -1     
==========================================
- Hits        46489    46485       -4     
- Misses       4176     4179       +3
Flag Coverage Δ
#multiple 90.26% <100%> (-0.01%) ⬇️
#single 41.73% <0%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/excel/_base.py 91.81% <100%> (-0.04%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.7% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba48fc4...8f619dd. Read the comment docs.

@gfyoung gfyoung merged commit e7f820d into pandas-dev:master May 25, 2019
@gfyoung
Copy link
Member

gfyoung commented May 25, 2019

Thanks @mroeschke !

@mroeschke mroeschke deleted the remove_parse_cols branch May 26, 2019 02:50
another-green pushed a commit to another-green/pandas that referenced this pull request May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean IO Excel read_excel, to_excel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants