TST/API: Forbid str-accessor for 1-level MultiIndex #26608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #26608 +/- ##
==========================================
- Coverage 91.88% 91.87% -0.01%
==========================================
Files 174 174
Lines 50692 50692
==========================================
- Hits 46576 46571 -5
- Misses 4116 4121 +5
Continue to review full report at Codecov.
|
jreback
requested changes
Jun 1, 2019
doc/source/whatsnew/v0.25.0.rst
Outdated
| @@ -434,6 +434,8 @@ Other API Changes | |||
| - The ``arg`` argument in :meth:`pandas.core.groupby.DataFrameGroupBy.agg` has been renamed to ``func`` (:issue:`26089`) | |||
| - The ``arg`` argument in :meth:`pandas.core.window._Window.aggregate` has been renamed to ``func`` (:issue:`26372`) | |||
| - Most Pandas classes had a ``__bytes__`` method, which was used for getting a python2-style bytestring representation of the object. This method has been removed as a part of dropping Python2 (:issue:`26447`) | |||
| - The `.str`-accessor has been disabled for 1-level :class:`MultiIndex` (almost all methods were previously broken for this case), | |||
There was a problem hiding this comment.
the parenthetical is not necessary
did this actually work at some point?
There was a problem hiding this comment.
The methods could be called but produced garbage, see #23679.
|
lgtm. pls merge master, ping on green. |
jreback
approved these changes
Jun 3, 2019
|
thanks |
vaibhavhrt
pushed a commit
to vaibhavhrt/pandas
that referenced
this pull request
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffAnother PR that had been blocked by #23167.