Deprecate Series/Dataframe.to_dense/to_sparse

[VikramjeetD]

• closes DEPR: deprecate Series/DataFrame.to_dense/to_sparse #26557
• passes git diff upstream/master -u -- "*.py" | flake8 --diff

Marks the methods mentioned in #26557 as deprecated, with proper messages.

[pep8speaks]

Hello @intell1gent! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-06-05 16:21:20 UTC

[codecov]

Codecov Report

Merging #26668 into master will decrease coverage by 50.09%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master   #26668      +/-   ##
==========================================
- Coverage   91.87%   41.78%   -50.1%     
==========================================
  Files         174      174              
  Lines       50663    50671       +8     
==========================================
- Hits        46548    21172   -25376     
- Misses       4115    29499   +25384

Flag	Coverage Δ
#multiple	?
#single	41.78% <50%> (-0.06%)	⬇️

Impacted Files	Coverage Δ
pandas/core/sparse/frame.py	28.37% <0%> (-67.26%)	⬇️
pandas/core/sparse/series.py	44.49% <0%> (-50.42%)	⬇️
pandas/core/frame.py	35.07% <100%> (-62.05%)	⬇️
pandas/core/series.py	45.42% <100%> (-48.19%)	⬇️
pandas/io/formats/latex.py	0% <0%> (-100%)	⬇️
pandas/io/sas/sas_constants.py	0% <0%> (-100%)	⬇️
pandas/core/groupby/categorical.py	0% <0%> (-100%)	⬇️
pandas/tseries/plotting.py	0% <0%> (-100%)	⬇️
pandas/tseries/converter.py	0% <0%> (-100%)	⬇️
pandas/io/formats/html.py	0% <0%> (-99.37%)	⬇️
... and 132 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0c41f7...39230d4. Read the comment docs.

[codecov]

Codecov Report

Merging #26668 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #26668      +/-   ##
==========================================
- Coverage   91.87%   91.87%   -0.01%     
==========================================
  Files         174      174              
  Lines       50663    50669       +6     
==========================================
+ Hits        46548    46550       +2     
- Misses       4115     4119       +4

Flag	Coverage Δ
#multiple	90.4% <100%> (ø)	⬆️
#single	41.75% <50%> (-0.09%)	⬇️

Impacted Files	Coverage Δ
pandas/core/sparse/frame.py	95.65% <100%> (+0.01%)	⬆️
pandas/core/frame.py	97% <100%> (-0.12%)	⬇️
pandas/core/series.py	93.62% <100%> (ø)	⬆️
pandas/core/sparse/series.py	94.93% <100%> (+0.02%)	⬆️
pandas/io/gbq.py	78.94% <0%> (-10.53%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0c41f7...39230d4. Read the comment docs.

[jorisvandenbossche]

@intell1gent is there a reason you closed this?

[VikramjeetD]

@intell1gent is there a reason you closed this?

@jorisvandenbossche Sorry, there was some confusion on my side. Opened a new PR ( #26684 ) since this has become a bit messy.

[jorisvandenbossche]

@intell1gent OK, will look at the other PR. Just a feedback for in the future: in general you don't need to make new PRs if something has become messy. If you clean up the branch locally and push again, the PR gets updated automatically.
Also, it is always recommended to work from a different branch than 'master' for a PR.