-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR: Deprecate Series/Dataframe.to_dense/to_sparse #26684
Merged
Merged
Changes from 5 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
a71737c
Deprecate Series/Dataframe.to_dense/to_sparse()
VikramjeetD fc08e93
Update series.py
VikramjeetD 82c713d
Beautify
VikramjeetD 39230d4
Beautify
VikramjeetD 1e7c0e8
Beautify
VikramjeetD e68826c
Update Deprecated SparseDF/Series tests
VikramjeetD 20b8962
Beautify
VikramjeetD 50d0534
Deprecate NDFrame.to_dense
VikramjeetD 933162d
Beautify
VikramjeetD dd1e6c2
Silence test time deprecation warnings
VikramjeetD c7f27fd
Beautify
VikramjeetD be14520
Propose changes to certain tests
VikramjeetD b12e447
Propose changes to tests. IGNORE PREV COMMIT.
VikramjeetD 2d4de51
Silence test time deprecation warnings
VikramjeetD eede9b8
Add tests for Series/DataFrame.to_sparse
VikramjeetD 0b08795
Beautify
VikramjeetD 5182a1f
Modify test time warning silence
VikramjeetD 15909c5
Modify groupby ops to remove NDFrame test warnings and add wcatch for…
VikramjeetD 104c12a
Remove filterwarning from test_hist_method.py
VikramjeetD e713fb0
Update sparsearray test_arithmetics warning
VikramjeetD 587b14f
Remove filterwarning from test_decimal.py
VikramjeetD 1318676
Beautify
VikramjeetD 9043e03
Merge branch 'master' of https://github.com/IntEll1gent/pandas
VikramjeetD 58c678a
Beautify
VikramjeetD ca14ac1
Merge branch 'master' of https://github.com/IntEll1gent/pandas
VikramjeetD 0c8f287
Update test warnings
VikramjeetD 871ccff
Merge remote-tracking branch 'upstream/master'
VikramjeetD a8f6c56
Update pandas/core/generic.py
VikramjeetD 72aaca5
Merge branch 'master' of https://github.com/IntEll1gent/pandas
VikramjeetD 6a6e333
Update test time warnings and rectify df/series.to_sparse double warn…
VikramjeetD 4e67856
Update more test time warnings
VikramjeetD 4a3181b
Update test warnings
VikramjeetD a546a89
Update test warnings
VikramjeetD 5fdb2f8
Revert minor changes
VikramjeetD a627828
Change location of Series/df.test_deprecated_to_sparse
VikramjeetD 3d36430
Remove SDF/SS.to_dense depr:class already deprecated
VikramjeetD 9f888c5
Add whatsnew entry
VikramjeetD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wont' this also trigger the SDF warnings? (should this just be changed to create a DF here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean the SDF deprecation warning? If thats the case, yes, but this was requested in the issue that this PR will address ( #26557 ).
Also, this might be helpful if someone has already hit the SDF warning through a different route, as a gentle reminder. Either way we could decide whats best and update accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it already triggers the SparseDataFrame warning. But, it is still good to explicitly deprecate this method as well (in the docs, and by giving a clearer warning message, although the other one will also still be present).
I don't think we should change the behaviour, since we are deprecating it (it would also be a backwards incompatible change, as DataFrame with sparse and SparseDataFrame are not fully interchangeable).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I think we can agree to keep both the warnings and resolve this conversation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually i would suppress the SDF
warning here as the user facing to_sparse is already good enough