Small cleanups #26874
Merged
Small cleanups #26874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
commented
Jun 16, 2019
| @property | ||
| def shape(self): | ||
| return (len(self),) | ||
|
|
There was a problem hiding this comment.
already defined in parent class
jbrockmendel
commented
Jun 16, 2019
| @@ -191,6 +191,8 @@ def _chk_truncate(self): | |||
| series = concat((series.iloc[:row_num], | |||
| series.iloc[-row_num:])) | |||
| self.tr_row_num = row_num | |||
| else: | |||
| self.tr_row_num = None | |||
There was a problem hiding this comment.
not a big deal, but this attribute should exist unconditionally
Codecov Report
@@ Coverage Diff @@
## master #26874 +/- ##
==========================================
- Coverage 91.88% 91.87% -0.02%
==========================================
Files 179 179
Lines 50696 50693 -3
==========================================
- Hits 46581 46573 -8
- Misses 4115 4120 +5
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #26874 +/- ##
==========================================
- Coverage 91.88% 91.87% -0.02%
==========================================
Files 179 179
Lines 50696 50693 -3
==========================================
- Hits 46581 46573 -8
- Misses 4115 4120 +5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken off from another branch to trim the diff on an upcoming PR.