DEPR: Series.put, Series.real, Series.imag, Index.dtype_str #27106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @mroeschke! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-06-28 21:44:10 UTC |
mroeschke
changed the title
jreback
requested changes
Jun 28, 2019
pandas/core/series.py
Outdated
| """ | ||
| warnings.warn("`imag` has be deprecated and will be removed in a " | ||
| "future verison", DeprecationWarning, stacklevel=2) |
There was a problem hiding this comment.
DeprecationWarning -> FutureWaring on all of these
doc/source/whatsnew/v0.25.0.rst
Outdated
| @@ -604,6 +604,9 @@ Other deprecations | |||
| - The :meth:`Series.ftype`, :meth:`Series.ftypes` and :meth:`DataFrame.ftypes` methods are deprecated and will be removed in a future version. | |||
| Instead, use :meth:`Series.dtype` and :meth:`DataFrame.dtypes` (:issue:`26705`). | |||
| - :meth:`Timedelta.resolution` is deprecated and replaced with :meth:`Timedelta.resolution_string`. In a future version, :meth:`Timedelta.resolution` will be changed to behave like the standard library :attr:`timedelta.resolution` (:issue:`21344`) | |||
| - :attr:`Index.dtype_str` is deprecated. (:issue:`18262`) | |||
| - :attr:`Series.imag` and :attr:`Series.real` is deprecated. (:issue:`18262`) | |||
|
can you add to the list in #6581 as well |
1 task
added 2 commits
June 28, 2019 16:41
|
Changed to FutureWarnings and green. |
jreback
approved these changes
Jun 28, 2019
|
thanks @mroeschke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffRemoves:
Series.putIndex.dtype_strSeries.realSeries.imag