-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR: NDFrame.set_axis inplace defaults to false #27525
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #27525 +/- ##
===========================================
- Coverage 92.96% 42.4% -50.57%
===========================================
Files 184 184
Lines 50339 50338 -1
===========================================
- Hits 46799 21346 -25453
- Misses 3540 28992 +25452
Continue to review full report at Codecov.
|
ghost
closed this
Jul 24, 2019
ghost
reopened this
Jul 24, 2019
ghost
closed this
Jul 25, 2019
ghost
deleted the
set_axis_inplace_default
branch
July 25, 2019 23:50
jreback
pushed a commit
that referenced
this pull request
Jul 26, 2019
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pandas/pandas/core/generic.py
Lines 594 to 598 in 76247c1
has been there since #20164, part of 0.21.0
With discussion of plans to deprecate similar functionality from set_index in #24046, it's time to make sure
set_axis
conforms to the rest of pandas in this.