Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: execute deprecations for str.cat in v1.0 #27611

Merged
merged 7 commits into from
Jul 31, 2019
Merged

DEPR: execute deprecations for str.cat in v1.0 #27611

merged 7 commits into from
Jul 31, 2019

Conversation

h-vetinari
Copy link
Contributor

  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

This executes some deprecations from the 0.23/0.24 cycles, namely following the switch from join=None to join='left' (following #18657 / #20347), as well as the fact that list-likes within list-likes were deprecated (following #21950 / #22264).

Since this deprecation closes the loop to my first-ever pandas issue (#18657) and PR (#20347), I'll allow myself a bit of a digression here. After biting off a bit more than I could chew (after finding out just how many cases the method was supposed to support), things got a bit tight with the cut-off for 0.23.0rc, and @TomAugspurger quipped:

@h-vetinari: Thanks for waiting with the cut-off! [...]

@TomAugspurger: Right, we'll keep you on the hook for future maintenance of this :)

After #20347 #20790 #20842 #20845 #20923 #21330 #21950 #22264 #22575 #22652 #22721 (-->#23011 #23163 #23167 #23582 ... and several more issues/PRs around .str-accessor) #22722 #22725 #23009 (-->#23061 #23065) #23187 #23443 #23723 #23725 #24044 #24045 #26605 #26607 etc., I think I can say that I upheld my end of the bargain. :)

jreback
jreback requested changes Jul 27, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. a question.

pandas/tests/test_strings.py Outdated
)

result = s.str.cat(t, sep=sep)
print(s, t, result)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra print

doc/source/whatsnew/v1.0.0.rst Outdated
@@ -45,7 +45,7 @@ Backwards incompatible API changes
Other API changes
^^^^^^^^^^^^^^^^^

-
- :meth:`pandas.Series.str.cat` now defaults to aligning ``others``, using ``join='left'`` (:issue:`27611`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this an api change? isn't it just a deprecation removal?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that changing the default of a kwarg qualifies more as an API change than a removal, but I don't mind either way. Let me know if you want me to shift it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a "Removal of prior version deprecations/changes" section, which IIUC is appropriate here.

@jreback jreback added Deprecate Functionality to remove in pandas Strings String extension data type and string data labels Jul 27, 2019
@jreback jreback added this to the 1.0 milestone Jul 27, 2019
@jreback jreback mentioned this pull request Jul 27, 2019
Closed
@jreback
Copy link
Contributor

jreback commented Jul 27, 2019

what other issues besides #22644 does this remove? (you can look on #6581 for what we have deprecated)

@h-vetinari
Copy link
Contributor Author

@jreback: what other issues besides #22644 does this remove? (you can look on #6581 for what we have deprecated)

I think you might have mistyped with #22644? At least I don't see a relation.

As mentioned in the OP:

@h-vetinari: This executes some deprecations from the 0.23/0.24 cycles, namely following the switch from join=None to join='left' (following #18657 / #20347), as well as the fact that list-likes within list-likes were deprecated (following #21950 / #22264).

@h-vetinari
Copy link
Contributor Author

Ping

@jreback jreback merged commit 9000c39 into pandas-dev:master Jul 31, 2019
@jreback
Copy link
Contributor

jreback commented Jul 31, 2019

thanks @h-vetinari

@h-vetinari h-vetinari deleted the str_cat_1.0 branch July 31, 2019 13:21
quintusdias pushed a commit to quintusdias/pandas_dev that referenced this pull request Aug 16, 2019
@h-vetinari @quintusdias
DEPR: execute deprecations for str.cat in v1.0 (pandas-dev#27611)
14d0b0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Strings String extension data type and string data
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@h-vetinari @jreback @TomAugspurger