CLN: collected cleanups from other branches #27723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Aug 4, 2019
| @@ -666,6 +666,7 @@ def test_comparison_tzawareness_compat_scalars(self, op, box_with_array): | |||
| # Raising in __eq__ will fallback to NumPy, which warns, fails, | |||
| # then re-raises the original exception. So we just need to ignore. | |||
| @pytest.mark.filterwarnings("ignore:elementwise comp:DeprecationWarning") | |||
| @pytest.mark.filterwarnings("ignore:Converting timezone-aware:FutureWarning") | |||
There was a problem hiding this comment.
is ignoring this warning actually hiding something?
There was a problem hiding this comment.
AFAICT it is just noise in the logs
| @@ -508,7 +508,7 @@ def test_datetime(): | |||
| desc_result = grouped.describe() | |||
|
|
|||
| idx = cats.codes.argsort() | |||
| ord_labels = cats.take_nd(idx) | |||
| ord_labels = cats.take(idx) # TODO: deprecate take<->take_nd alias | |||
There was a problem hiding this comment.
can you make an issue (and remove the comment)
|
I think this is fine, but can you rebase anyways |
jreback
approved these changes
Aug 5, 2019
|
Rebased and green |
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.