Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ix, part 1 #28884

Closed
wants to merge 1 commit into from
Closed

Conversation

topper-123
Copy link
Contributor

First part of removal od NDFrame.ix. There's still alot of tests for this, so I'll do this removal in 2-3 steps. This PR removes pandas/tests/indexing/test_ix.py and tests for ix in a few more places.

@topper-123 topper-123 added Deprecate Functionality to remove in pandas Indexing Related to indexing on series/frames, not to indexes themselves labels Oct 10, 2019
@topper-123 topper-123 added this to the 1.0 milestone Oct 10, 2019
@topper-123
Copy link
Contributor Author

Just seen #6581, where it says ix is to be removed in 1.2. So this is perhaps too early?

@WillAyd
Copy link
Member

WillAyd commented Oct 10, 2019

Anything deprecated prior to 0.25 is good to remove for 1.0, so no issue there.

There is however #27620 out there as well

@jreback
Copy link
Contributor

jreback commented Oct 10, 2019

ix is good to remove now

@topper-123
Copy link
Contributor Author

I’ll just close this down, given that #27620 is already on this...

@topper-123 topper-123 closed this Oct 10, 2019
@topper-123 topper-123 removed this from the 1.0 milestone Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants