BUG: Fix comparison between nullable int and string #28945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix here makes sense. Are there any other types we could compare against that this fixes? e.g. |
|
Merging master should fix the CI failures. |
jreback
requested changes
Oct 16, 2019
jreback
added
Compat
|
The CI failures seem to be from tests on cummin and cummax for Series with datetime64 and timedelta64 dtypes |
WillAyd
requested changes
Oct 22, 2019
jreback
reviewed
Oct 22, 2019
|
@dsaxton can you fix up merge conflict? |
jreback
requested changes
Dec 8, 2019
pandas/core/arrays/integer.py
Outdated
| @@ -652,7 +653,13 @@ def cmp_method(self, other): | |||
| with warnings.catch_warnings(): | |||
| warnings.filterwarnings("ignore", "elementwise", FutureWarning) | |||
| with np.errstate(all="ignore"): | |||
| result = op(self._data, other) | |||
| method = getattr( | |||
| self._data, "__{op_name}__".format(op_name=op_name) | |||
There was a problem hiding this comment.
can you change this to a f-string
jreback
approved these changes
Dec 10, 2019
|
thanks @dsaxton |
NP, thanks for the review |
jorisvandenbossche
added
Bug
and removed
Compat
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandas