Remove TestData from series-tests test_api.py #29153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replaced TestData usage in pandas/tests/series/test_api.py with fixtures
20 tasks
simonjayhawkins
requested changes
Oct 22, 2019
There was a problem hiding this comment.
@SaturnFromTitan thanks for the PR.
can you split the tests where the two fixtures are tested independently
…ries simultaniously
SaturnFromTitan
force-pushed
the
remove-testdata-in-series-tests_test_api
branch
from
509e116
to
b85a985
Compare
SaturnFromTitan
commented
Oct 22, 2019
|
|
||
| # assert is lazy (genrators don't define reverse, lists do) | ||
| assert not hasattr(self.series.items(), "reverse") | ||
| assert not hasattr(string_series.items(), "reverse") |
There was a problem hiding this comment.
I don't get why this is part of the test, but I left it as it was there before. Currently, it's only part of the string_series tests for .items and .iteritems, but not for the datetime_series ones (same as it was before).
@simonjayhawkins What's your take on removing it vs leaving as is?
There was a problem hiding this comment.
I think fine to leave as is.
simonjayhawkins
approved these changes
Oct 22, 2019
WillAyd
approved these changes
Oct 22, 2019
|
Thanks @SaturnFromTitan very nice cleanup |
HawkinsBA
pushed a commit
to HawkinsBA/pandas
that referenced
this pull request
Oct 29, 2019
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #22550
pandas/tests/series/test_api.pywith fixturesblack pandasgit diff upstream/master -u -- "*.py" | flake8 --diff