DEPR: is_extension_type

[jbrockmendel]

It is mostly redundant with is_extension_array_dtype, and having both is confusing.

xref #23179.

[WillAyd]

Can this not be removed outright? It's non-public and sits behind an experimental interface, so I think not worth the effort of a deprecation cycle

[jbrockmendel]

i wouldnt shed any tears if we removed it altogether

[WillAyd]

I'm +1 to outright remove but let's see what @TomAugspurger and @jreback think

[jreback]

is this in pd.api.types?

if not ok to remove

[TomAugspurger]

It’s not public right? So fine to just remove. This predated the EA interface.

…

On Nov 7, 2019, at 18:23, William Ayd ***@***.***> wrote:  I'm +1 to outright remove but let's see what @TomAugspurger and @jreback think — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[jbrockmendel]

is this in pd.api.types?

Yes, this is in pd.api.types. (via a * import)

[jreback]

is this in pd.api.types?

Yes, this is in pd.api.types. (via a * import)

really? it has a test that catches the earning?

[jbrockmendel]

We have tests (updated appropriately in this PR) for deprecated functions in this module.

…

On Thu, Nov 7, 2019 at 5:29 PM Jeff Reback ***@***.***> wrote: is this in pd.api.types? Yes, this is in pd.api.types. (via a * import) really? it has a test that catches the earning? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#29457?email_source=notifications&email_token=AB5UM6CRGPV2CITZPCDWCB3QSS6GNA5CNFSM4JKBUAJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDONGXQ#issuecomment-551342942>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5UM6DGRZX6UENGSIFMSMDQSS6GNANCNFSM4JKBUAJQ> .

[jreback]

ok i see the change now, yeah have to deprecate

can u add to the master depreciation issue (or create say a 1.2 removals issue)

[jbrockmendel]

can u add to the master depreciation issue (or create say a 1.2 removals issue)

will do

[jreback]

thanks @jbrockmendel