DEPR: loc with listlikes with missing elements #29802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Nov 25, 2019
pandas/tests/indexing/test_iloc.py
Outdated
| result = df2.loc[idx] | ||
| tm.assert_frame_equal(result, expected, check_index_type=False) | ||
| with pytest.raises(KeyError, match="with any missing labels"): | ||
| # TODO: should non-uniquness play a part in the error message? |
There was a problem hiding this comment.
hmm, yes I would agree here
There was a problem hiding this comment.
sounds good, ill see what i can do here.
BTW in #6581 are we removing things in the 0.25.0 section or only the earlier ones?
There was a problem hiding this comment.
hmm the non-uniqueness doesn't seem to play any part in us getting here, so im now leaning towards not having a special message
|
rebased+green |
jreback
reviewed
Nov 27, 2019
jreback
approved these changes
Nov 29, 2019
|
thanks @jbrockmendel |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm less confident in this one than in others. Some of the affected tests seem to involve non-missing labels in duplicate-containing indexes. Did I conflate multiple issues/deprecations?