Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: deprecate truediv param in pd.eval #29812

Merged
merged 5 commits into from
Nov 25, 2019

Conversation

jbrockmendel
Copy link
Member

No description provided.

@WillAyd WillAyd added the Deprecate Functionality to remove in pandas label Nov 23, 2019
@WillAyd
Copy link
Member

WillAyd commented Nov 23, 2019

Makes sense to me - can you add a whatsnew note?

@WillAyd WillAyd added this to the 1.0 milestone Nov 23, 2019
@@ -2006,6 +2006,22 @@ def test_inf(engine, parser):
assert result == expected


def test_truediv_deprecated(engine, parser):
match = "The `truediv` parameter in pd.eval is deprecated"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference issue number above.

@jreback jreback merged commit 06790d7 into pandas-dev:master Nov 25, 2019
@jreback
Copy link
Contributor

jreback commented Nov 25, 2019

cool, can you add this to the deprecations issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants