DEPR: Change raw kwarg in rolling/expanding.apply to False #29829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Deprecate
| @@ -1214,27 +1209,15 @@ def count(self): | |||
| """ | |||
| ) | |||
|
|
|||
| def apply(self, func, raw=None, args=(), kwargs={}): | |||
| def apply(self, func, raw=False, args=(), kwargs={}): | |||
There was a problem hiding this comment.
can this now be annotated?
Doesnt have to be for this PR, but kwargs should be changed to not have a mutable default
There was a problem hiding this comment.
I can do both in a follow up.
Agreed that this should be kwargs=None. The docstring is misleading as well since it says apply takes **kwargs so reason enough for a cleanup + full change here.
|
small comment, not a blocker. LGTM |
|
thanks @mroeschke can you update the deprecations issue as well (move to completed) |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff