BUG/DEPR: Timestamp/Timedelta resolution #29910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Nov 28, 2019
| @@ -804,9 +804,13 @@ def test_resolution_string(self): | |||
| def test_resolution_deprecated(self): | |||
There was a problem hiding this comment.
Maybe rename this test to just test_resolution
mroeschke
reviewed
Nov 28, 2019
pandas/_libs/tslibs/timedeltas.pyx
Outdated
| @@ -1602,3 +1552,4 @@ cdef _broadcast_floordiv_td64(int64_t value, object other, | |||
| # resolution in ns | |||
| Timedelta.min = Timedelta(np.iinfo(np.int64).min + 1) | |||
| Timedelta.max = Timedelta(np.iinfo(np.int64).max) | |||
| Timedelta.resolution = Timedelta(nanoseconds=1) | |||
There was a problem hiding this comment.
Think a newline is needed here.
WillAyd
added
Deprecate
|
updated+green |
|
Thanks @jbrockmendel |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
* BUG/DEPR: Timestamp/Timedelta resolution * GH ref
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
* BUG/DEPR: Timestamp/Timedelta resolution * GH ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timedelta.resolution used to return a string, but that was deprecated in 0.25.0. Enforce that deprecation to return Timedelta(nanoseconds=1), mirroring the stdlib timedelta.resolution behavior.
Timestamp.resolution correctly mirrors datetime.resolution by returning Timedelta(nanoseconds=1), but it is a property whereas for the stdlib it is a class attribute. This PR makes it a class attribute for Timestamp.