Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Highlighting flake8 and grep errors in GitHub Actions #29915

Merged
merged 3 commits into from
Nov 29, 2019
Merged

CI: Highlighting flake8 and grep errors in GitHub Actions #29915

merged 3 commits into from
Nov 29, 2019

Conversation

datapythonista
Copy link
Member

Our code checks genereated the output in a way that Azure pipelines was highlighting the errors. In GitHub actions it's possible to do more or less the same, but with a different syntax. Changing the syntax here, and simplifying some tricky parts in the script.

Introducing some errors, so we can see how it looks.

@datapythonista datapythonista added CI Continuous Integration Clean labels Nov 28, 2019
@pep8speaks
Copy link

pep8speaks commented Nov 28, 2019

Hello @datapythonista! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 20:56: W291 trailing whitespace
Line 24:27: W291 trailing whitespace

Comment last updated at 2019-11-28 14:31:10 UTC

@jbrockmendel
Copy link
Member

neat

@alimcmaster1
Copy link
Member

alimcmaster1 commented Nov 28, 2019

This might a different issue but I think all steps should run and not just exit when a step fails.

Its annoying to fix one issue only to be confronted by another on the next run. What do you think?

image

@datapythonista
Copy link
Member Author

This might a different issue but I think all steps should run and not just exit when a step fails.

I think this is a problem with GitHub. This was working as expected, and the configuration didn't change. If they don't fix it in couple of days I'll report it, and see what they say.

@jreback jreback added this to the 1.0 milestone Nov 29, 2019
@jreback jreback merged commit 8ffecdc into pandas-dev:master Nov 29, 2019
@jreback
Copy link
Contributor

jreback commented Nov 29, 2019

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Clean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants