ENH: support datetime64, datetime64tz in nanops.mean, nanops.median #29941
Conversation
jreback
added
Missing-data
pandas/core/frame.py
Outdated
| # e.g. in nanops trying to convert strs to float | ||
| # TODO: the ValueError is raised in trying to convert str |
There was a problem hiding this comment.
yes this should be a TypeError, where is the ValueError coming from?
There was a problem hiding this comment.
what is trying to convert to str?
There was a problem hiding this comment.
do you still need this ValueError? (as i think you changed below)
There was a problem hiding this comment.
i'll re-run without catching ValueError. IIRC it was in nanops._ensure_numeric
There was a problem hiding this comment.
yah, there are 3 tests where x.astype(np.float64) raises a ValueError in _ensure_numeric with a object-dtype x that contains a string.
There was a problem hiding this comment.
just removed this and re-raised as TypeError on nanops 1292-1296
jbrockmendel
changed the title
pandas/core/frame.py
Outdated
| # e.g. in nanops trying to convert strs to float | ||
| # TODO: the ValueError is raised in trying to convert str |
There was a problem hiding this comment.
what is trying to convert to str?
pandas/core/frame.py
Outdated
| # e.g. in nanops trying to convert strs to float | ||
| # TODO: the ValueError is raised in trying to convert str |
There was a problem hiding this comment.
do you still need this ValueError? (as i think you changed below)
|
this looks good. can you add a deprecation note in whatsnew and rebase. |
|
whatsnew added, rebased+green |
|
lgtm. once more rebase and merge on green. (also add to the deprecated issue tracker as well). |
|
Thanks @jbrockmendel |
Tracking down relevant issues and figuring out test coverage is the "WIP" part of this.