Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: change parameter name fname -> path #30338

Merged
merged 3 commits into from
Dec 19, 2019

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel
Copy link
Member Author

@datapythonista i think we discussed this recently: is there a way to make the docbuild output easier to identify the part that went wrong? Also would be nice to have a way to test locally instead of having to flood the CI

@datapythonista
Copy link
Member

I think for the docs is not trivial to generate the output in a GutHub Actions friendly way. I guess we can do the sed hack in the bash script, if the sphinx output has a consistent format.

But a better fix would be to implement a Sphinx extension, less hacky, and it could be reused by other projects.

Not sure what do you mean by testing locally. What can't we test locally?

@jreback jreback added IO Parquet parquet, feather Deprecate Functionality to remove in pandas labels Dec 19, 2019
@jreback jreback added this to the 1.0 milestone Dec 19, 2019
@jreback jreback merged commit f8b9ce7 into pandas-dev:master Dec 19, 2019
@jbrockmendel
Copy link
Member Author

Not sure what do you mean by testing locally. What can't we test locally?

I mean doing the docbuild locally so i can troubleshoot it without clogging the CI.

You've already gone above-and-beyond in making the CI easier to use, don't worry about this nitpicking.

@datapythonista
Copy link
Member

if you installed the dependencies in the root environment.yml file, building the docs locally should be as easy as running . /doc/make.py html. I don't think anything else is missing, not sure if I'm missing something.

I'll have a look at making the errors in the output of the docs easier to find. I think those things are worth, since they save all us a significant amount of time. But I'll check for GitHub actions, since we're moving the docs build there. So it'll have to wait until #29874 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas IO Parquet parquet, feather
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Name of fname Parameter to path in Parquet IO Methods
3 participants