-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REF: change parameter name fname -> path #30338
Conversation
@datapythonista i think we discussed this recently: is there a way to make the docbuild output easier to identify the part that went wrong? Also would be nice to have a way to test locally instead of having to flood the CI |
I think for the docs is not trivial to generate the output in a GutHub Actions friendly way. I guess we can do the But a better fix would be to implement a Sphinx extension, less hacky, and it could be reused by other projects. Not sure what do you mean by testing locally. What can't we test locally? |
I mean doing the docbuild locally so i can troubleshoot it without clogging the CI. You've already gone above-and-beyond in making the CI easier to use, don't worry about this nitpicking. |
if you installed the dependencies in the root I'll have a look at making the errors in the output of the docs easier to find. I think those things are worth, since they save all us a significant amount of time. But I'll check for GitHub actions, since we're moving the docs build there. So it'll have to wait until #29874 is merged. |
fname
Parameter topath
in Parquet IO Methods #23574black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff