-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some pprint_thing warts #3038
Conversation
added notes to 0.11.0., but maybe this should wait until 0.12/0.11.1 also, make Timstemp repr executable, like datetime. |
@y-p I only found the 1 case where a NaN was actually passed to pprint_thing (in index.py/format, which I fixed) |
yep. what bothers you about these changes? |
is there a test case where Part 1 actually occurs? |
say there isn't. Why should None be invisible, even in theory? |
oh...nothing....they look fine...just curios (I have always though we should ALWAYS convert None anyhow...but that is a separate issue) |
I must have written that at the spur of some 4am moment, "that's no basis for a system of government". |
that's pretty funny! |
rebase fail, redone with 4aea3f2 |
Part 1
currently:
after PR:
and jeff fixed index NaN printing in #3034, at a higher level.
Part 2
currently:
after PR:
so:
Which is what
repr()
should enable, in principle.