BUG: Fix wrong error in df drop with non unique datetime index and invalid keys #30446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujiaxiang
changed the title
WillAyd
requested changes
Dec 24, 2019
| # create dataframe with non-unique datetime index | ||
| df_nonunique = df_unique.copy().iloc[[0, 2, 2, 3]] | ||
|
|
||
| try: |
There was a problem hiding this comment.
I think the point of this is the raise a KeyError for the example specified - can you model the test to use pytest.raises instead? Should see other examples of this in the code base
There was a problem hiding this comment.
Have updated the code as requested. Now the test specifically expects KeyError with string "not found in axis" within the message
WillAyd
requested changes
Dec 24, 2019
There was a problem hiding this comment.
Looks good minor nit on whatsnew - @jorisvandenbossche care to look?
Co-Authored-By: William Ayd <william.ayd@icloud.com>
…_datetime_index_and_invalid_keys
|
thanks @fujiaxiang |
fujiaxiang
deleted the
fix_wrong_error_in_df_drop_with_non_unique_datetime_index_and_invalid_keys
branch
fujiaxiang
added a commit
to fujiaxiang/pandas
that referenced
this pull request
Dec 26, 2019
AlexKirko
pushed a commit
to AlexKirko/pandas
that referenced
this pull request
Dec 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff