ENH: Allow setitem in a frame where only mixed numerics are present #3050
+51
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e.g. int and float) GH 3037 CLN: minor change in _consolidate_inplace (check if consolidated first, so that we can cheaply call this)
|
@wesm any objection? (I didn't want to change the API and actually allow setting on a mixed frame, which though can make it work, a bit werid) |
|
Fine by me |
jreback
added a commit
that referenced
this pull request
Mar 15, 2013
ENH: Allow setitem in a frame where only mixed numerics are present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this implements #3037
previously would failed if mixed_types was true,
so mixed int/float would fail