Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: is_copy arg of take #30615

Merged
merged 13 commits into from
Jan 6, 2020
Merged

DEPR: is_copy arg of take #30615

merged 13 commits into from
Jan 6, 2020

Commits on Jan 5, 2020

  1. deprecate is_copy argument of take and remove is_copy=False usage

    @ryankarlos
    ryankarlos committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    1e1b4f1 View commit details
    Browse the repository at this point in the history

  2. add test for depr is_copy

    @ryankarlos
    ryankarlos committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    17ca686 View commit details
    Browse the repository at this point in the history

  3. add whats new note

    @ryankarlos
    ryankarlos committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    9bd696c View commit details
    Browse the repository at this point in the history

  4. Fix condition for is_copy to avoid breaking other tests

    @ryankarlos
    ryankarlos committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    dabe051 View commit details
    Browse the repository at this point in the history

  5. linting

    @ryankarlos
    ryankarlos committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    8142050 View commit details
    Browse the repository at this point in the history

  6. correct typing for is_copy arg

    @ryankarlos
    ryankarlos committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    277d925 View commit details
    Browse the repository at this point in the history

  7. Fix CI errors

    @ryankarlos
    ryankarlos committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    d8db903 View commit details
    Browse the repository at this point in the history

  8. catch warnings in test_asof

    @ryankarlos
    ryankarlos committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    88dfc50 View commit details
    Browse the repository at this point in the history

  9. fix merge conflict and linting

    @ryankarlos
    ryankarlos committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    7c533a1 View commit details
    Browse the repository at this point in the history

  10. revert warnings filtering in tests

    @ryankarlos
    ryankarlos committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    87b1ba5 View commit details
    Browse the repository at this point in the history

  11. switch to is_copy default None in asof

    @ryankarlos
    ryankarlos committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    6c1d495 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2020

  1. fix merge conflict

    @ryankarlos
    ryankarlos committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    0798283 View commit details
    Browse the repository at this point in the history

  2. remove blank line

    @ryankarlos
    ryankarlos committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    e914148 View commit details
    Browse the repository at this point in the history