Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: delegate more IntervalIndex methods #30626

Merged
merged 2 commits into from
Jan 3, 2020

Conversation

jbrockmendel
Copy link
Member

cc @jschendel is the usage of _simple_new instead of _shallow_copy take important? Should it always be the case that idx.close == idx._data.closed?

@jreback jreback added Interval Interval data type Refactor Internal refactoring of code labels Jan 3, 2020
@jreback jreback added this to the 1.0 milestone Jan 3, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @jschendel

@jschendel
Copy link
Member

is the usage of _simple_new instead of _shallow_copy in take important?

I don't think so.

should it always be the case that idx.closed == idx._data.closed?

Yes.

@jschendel jschendel merged commit dd0d353 into pandas-dev:master Jan 3, 2020
@jschendel
Copy link
Member

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ref-ii branch January 3, 2020 15:20
Index([(0.0, 1.0), nan, (2.0, 3.0)], dtype='object')
""",
)
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By removing this, the docstring of IntervalIndex.to_tuples is now no longer correct (and misses the example).

The delegation mechanism will need a way to change docstrings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Interval Interval data type Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants