DEPR: Deprecate numpy argument in read_json #30636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Luca Ionescu <lucaionescu@users.noreply.github.com>
alimcmaster1
changed the title
jreback
added
Deprecate
5 tasks
jreback
requested changes
Jan 3, 2020
pandas/tests/io/json/test_pandas.py
Outdated
| # https://github.com/pandas-dev/pandas/issues/28512 | ||
| expected = DataFrame([1, 2, 3]) | ||
| with tm.assert_produces_warning(None): | ||
| with catch_warnings(): |
There was a problem hiding this comment.
why are you catching warnings here?
There was a problem hiding this comment.
Yep unsure why this was in #28562. Now simplified
WillAyd
requested changes
Jan 3, 2020
jreback
requested changes
Jan 4, 2020
setup.cfg
Outdated
| @@ -66,6 +66,7 @@ xfail_strict = True | |||
| filterwarnings = | |||
| error:Sparse:FutureWarning | |||
| error:The SparseArray:FutureWarning | |||
| ignore: the 'numpy' keyword is deprecated:FutureWarning | |||
There was a problem hiding this comment.
don't do this, instead wrap the appropriate tests
alimcmaster1
changed the title
|
Can you merge master? |
done! |
WillAyd
approved these changes
Jan 7, 2020
|
friendly ping @jreback |
jreback
approved these changes
Jan 9, 2020
|
thanks @alimcmaster1 very nice! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Luca Ionescu lucaionescu@users.noreply.github.com
@lucaionescu - i've merged master and pushed to here (I don't have the permissions to push to your branch), I will aim to fix up the tests. Or feel free to take it from here if you have time?
Opening up WIP PR to see what test failures need addressing.
I've also co-authored the commit.