DEPR: indexing Series with single-entry list #31333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
added
Deprecate
There was a problem hiding this comment.
This seems reasonable. Will users see this warning in addition to the warnings in #31299 (comment)?
Will need a whatsnew note.
| # GH#31299 | ||
| warnings.warn( | ||
| "Indexing with a single-item list containing a " | ||
| "slice is deprecated and will raise in a future " |
There was a problem hiding this comment.
Do we know what it will raise? Or will it depend on the value?
There was a problem hiding this comment.
Best guess is TypeError, depends on where we let it fall through
No, this will change the list to tuple before calling
updated |
|
thanks, can you add to the deprecation issue (do this for anything we are deprecating). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffCould use a better warning message, suggestions welcome.