Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG accept and deprecate negative integer for max_colwidth #31569

Merged
merged 11 commits into from
Feb 2, 2020

Conversation

glemaitre
Copy link
Contributor

@glemaitre glemaitre commented Feb 2, 2020

@glemaitre glemaitre changed the title [WIP] BUG accept and deprecate negative integer for max_colwidth BUG accept and deprecate negative integer for max_colwidth Feb 2, 2020
@glemaitre
Copy link
Contributor Author

Do you have an entry point in the documentation to add the removal of support for version 1.2, to ease the maintanance on your side?

@glemaitre
Copy link
Contributor Author

glemaitre commented Feb 2, 2020

So from the tests failing it seems is_nonnegative_int will handle None while is_int will not.
It seems a bit surprising at first. @jorisvandenbossche would it make sense that they behave the same? Probably this just an internal function anyway.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, ping when revised and green (also merge master).

doc/source/whatsnew/v1.0.1.rst Outdated Show resolved Hide resolved
doc/source/whatsnew/v1.0.1.rst Outdated Show resolved Hide resolved
pandas/core/config_init.py Outdated Show resolved Hide resolved
pandas/tests/io/formats/test_format.py Outdated Show resolved Hide resolved
@jreback jreback added this to the 1.0.1 milestone Feb 2, 2020
@jreback jreback added Output-Formatting __repr__ of pandas objects, to_string Deprecate Functionality to remove in pandas labels Feb 2, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. ping on green.

@glemaitre
Copy link
Contributor Author

ping @jreback it's green :)

@jreback jreback merged commit 8dfb549 into pandas-dev:master Feb 2, 2020
@lumberbot-app
Copy link

lumberbot-app bot commented Feb 2, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 1.0.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 8dfb54967a935562e3379f999a696fdd1b4ba545
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #31569: BUG accept and deprecate negative integer for max_colwidth'
  1. Push to a named branch :
git push YOURFORK 1.0.x:auto-backport-of-pr-31569-on-1.0.x
  1. Create a PR against branch 1.0.x, I would have named this PR:

"Backport PR #31569 on branch 1.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@jreback
Copy link
Contributor

jreback commented Feb 2, 2020

thanks @glemaitre

@jreback
Copy link
Contributor

jreback commented Feb 2, 2020

@glemaitre if u want to do the manual back port above would be great

@glemaitre
Copy link
Contributor Author

I'll do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Output-Formatting __repr__ of pandas objects, to_string
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG display.max_colwidth do not accept -1 for unlimited width
4 participants