Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: GH29547 replace old string formatting #32063

Merged
merged 5 commits into from
Feb 18, 2020
Merged

CLN: GH29547 replace old string formatting #32063

merged 5 commits into from
Feb 18, 2020

Conversation

pcandoalmeida
Copy link
Contributor

Hi there! I've added some missed f-strings to:

  • tests/tslibs
  • tests/tseries
  • tests passed
  • passes black pandas

Thank you.

simonjayhawkins
simonjayhawkins approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pcandoalmeida lgtm pending green

@simonjayhawkins simonjayhawkins added the Code Style Code style, linting, code_checks label Feb 17, 2020
@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Feb 17, 2020
datapythonista
datapythonista approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the error in the CI is caused by #31156, but can't see why.

@stijnvanhoey any idea what can be wrong?

@stijnvanhoey
Copy link
Contributor 

 Extension error:
Could not import extension contributors (exception: No module named 'gitdb.utils.compat')
##[error]Process completed with exit code 2.

We did not encounter this error during the setup, https://github.com/pandas-dev/pandas/pull/31156/checks?check_run_id=411825801. I do not have a specific idea to which this refers. @jorisvandenbossche, do you have an idea?

@jorisvandenbossche
Copy link
Member

See #32060

@TomAugspurger
Copy link
Contributor

@pcandoalmeida can you merge master and re-push? Then CI should be passing.

@pcandoalmeida
Copy link
Contributor Author

Hi @TomAugspurger I've merged master and pushed now. Thanks!

@simonjayhawkins simonjayhawkins merged commit bdc7fd0 into pandas-dev:master Feb 18, 2020
@simonjayhawkins
Copy link
Member

Thanks @pcandoalmeida

@pcandoalmeida pcandoalmeida deleted the 29547-fstring-update branch February 18, 2020 15:18
@pcandoalmeida pcandoalmeida mentioned this pull request Feb 18, 2020
Closed
99 tasks
3vts added a commit to 3vts/pandas that referenced this pull request Feb 19, 2020
@3vts
Revert "CLN: GH29547 replace old string formatting (pandas-dev#32063)"
0ef2ce0 
This reverts commit bdc7fd0.
roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
@pcandoalmeida @roberthdevries
CLN: GH29547 replace old string formatting (pandas-dev#32063)
6a051ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

@datapythonista datapythonista datapythonista approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
6 participants
@pcandoalmeida @stijnvanhoey @jorisvandenbossche @TomAugspurger @simonjayhawkins @datapythonista