Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: take into account adjoin width, closes #3201 #3208

Merged
merged 1 commit into from
Apr 10, 2013
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions pandas/core/format.py
Original file line number Diff line number Diff line change
Expand Up @@ -317,10 +317,11 @@ def to_string(self, force_unicode=None):

def _join_multiline(self, *strcols):
lwidth = self.line_width
adjoin_width = 1
strcols = list(strcols)
if self.index:
idx = strcols.pop(0)
lwidth -= np.array([len(x) for x in idx]).max()
lwidth -= np.array([len(x) for x in idx]).max() + adjoin_width

col_widths = [np.array([len(x) for x in col]).max()
if len(col) > 0 else 0
Expand All @@ -339,7 +340,7 @@ def _join_multiline(self, *strcols):
else:
row.append([' '] * len(self.frame))

str_lst.append(adjoin(1, *row))
str_lst.append(adjoin(adjoin_width, *row))
st = ed
return '\n\n'.join(str_lst)

Expand Down Expand Up @@ -1765,14 +1766,21 @@ def _put_lines(buf, lines):
buf.write('\n'.join(lines))


def _binify(cols, width):
def _binify(cols, line_width):
adjoin_width = 1
bins = []
curr_width = 0
i_last_column = len(cols) - 1
for i, w in enumerate(cols):
curr_width += w
if curr_width + 2 > width and i > 0:
w_adjoined = w + adjoin_width
curr_width += w_adjoined
if i_last_column == i:
wrap = curr_width + 1 > line_width and i > 0
else:
wrap = curr_width + 2 > line_width and i > 0
if wrap:
bins.append(i)
curr_width = w
curr_width = w_adjoined

bins.append(len(cols))
return bins
Expand Down
5 changes: 5 additions & 0 deletions pandas/tests/test_format.py
Original file line number Diff line number Diff line change
Expand Up @@ -909,6 +909,11 @@ def test_to_string_format_na(self):
'4 4 bar')
self.assertEqual(result, expected)

def test_to_string_line_width(self):
df = pd.DataFrame(123, range(10, 15), range(30))
s = df.to_string(line_width=80)
self.assertEqual(max(len(l) for l in s.split('\n')), 80)

def test_to_html(self):
# big mixed
biggie = DataFrame({'A': randn(200),
Expand Down