Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: enable bionic & multi-cpu testing #32237

Closed
wants to merge 1 commit into from
Closed

Conversation

xnox
Copy link

@xnox xnox commented Feb 25, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback
Copy link
Contributor

jreback commented Feb 25, 2020

what does this actually do? (the arch directive)

@xnox
Copy link
Author

xnox commented Feb 25, 2020

what does this actually do? (the arch directive)

spins up Ubuntu LXD containers on arm64, s390x (big endian, 64bit mainframe), ppc64el (POWER8 6bit little endian), amd64 metal and lets one build & run code on those architectures, thanks to hardware that Travis got from partners.

@xnox
Copy link
Author

xnox commented Feb 25, 2020

@jreback you can see from https://travis-ci.org/pandas-dev/pandas/builds/654862395?utm_source=github_status&utm_medium=notification that all tests on non-x86 are currently failing.

Similarly this is the reason we can't update pandas in Ubuntu 20.04 LTS for the release in april at the moment - https://launchpad.net/ubuntu/+source/pandas/0.25.3+dfsg-5

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sympathetic with the request. however we have 0 support for non-standard arches. that said, if it can be made to work great.

I would start really small though, enable 1 thing (on an failing ok build), then would take patches to fix.

Almost everything would need to be build from source if conda is not available (IIRC this is somewhat supported for the arm arches but nothing else)

@jreback
Copy link
Contributor

jreback commented Feb 25, 2020

@xnox we also don't have the capacity to actually have multi arch on every build.

@WillAyd
Copy link
Member

WillAyd commented Feb 25, 2020

@xnox is there also infrastructure for building wheels on these platforms?

@jbrockmendel jbrockmendel added the CI Continuous Integration label Feb 28, 2020
@ShaharNaveh
Copy link
Member

@WillAyd I had a very good experience with https://github.com/joerick/cibuildwheel

@jreback
Copy link
Contributor

jreback commented Mar 15, 2020

we would only need a single build on each arch, need a PR more like: #30641

@jreback jreback closed this Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants