Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: pd.ExcelFile closes stream on destruction #32544

Merged
merged 9 commits into from
Mar 12, 2020
Merged

BUG: pd.ExcelFile closes stream on destruction #32544

merged 9 commits into from
Mar 12, 2020

Commits on Mar 11, 2020

  1. FIX: pandas.ExcelFile should not close stream passed as parameter on … 

    …destruction

Regression test added

Bonus: refactor closing of openpyxl file into openpyxl class instead
of anti-pattern check in ExcelFile.close() for openpyxl engine
    @roberthdevries
    roberthdevries committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    9b018f6 View commit details
    Browse the repository at this point in the history

  2. Fix from black reformatter

    @roberthdevries
    roberthdevries committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    3c81041 View commit details
    Browse the repository at this point in the history

  3. Add whatsnew entry

    @roberthdevries
    roberthdevries committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    22a06fc View commit details
    Browse the repository at this point in the history

  4. Remove unused import

    @roberthdevries
    roberthdevries committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    9b9fff9 View commit details
    Browse the repository at this point in the history

  5. Revert "Fix warning in unit test" 

    This reverts commit 002f1e0.
    @roberthdevries
    roberthdevries committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    443780d View commit details
    Browse the repository at this point in the history

  6. Change the close() method of the _BaseExcelReader class

    @roberthdevries
    roberthdevries committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    58e83fb View commit details
    Browse the repository at this point in the history

  7. Moved whatsnew entry from v1.1.0 to v1.0.2

    @roberthdevries
    roberthdevries committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    7609675 View commit details
    Browse the repository at this point in the history

  8. Remove left-over change

    @roberthdevries
    roberthdevries committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    509f203 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2020

  1. Merge remote-tracking branch 'upstream/master' into fix-31467-pd.Exce… 

    …lFile-closes-stream-on-destruction
    @TomAugspurger
    TomAugspurger committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    a8ea7bb View commit details
    Browse the repository at this point in the history