-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PERF: fix performance regression in memory_usage(deep=True) for object dtype #33102
PERF: fix performance regression in memory_usage(deep=True) for object dtype #33102
Conversation
@jbrockmendel thoughts? |
LGTM. @jorisvandenbossche has stronger opinions than i do on when to use |
@jbrockmendel This is not about an opinion on when to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @neilkg !
Looks good to me
@neilkg Can you please merge master? https://dev.pandas.io/docs/development/contributing.html#updating-your-pull-request |
@MomIsBestFriend done |
Thanks @neilkg! |
…ory_usage(deep=True) for object dtype
this was tagged for 1.04? hmm not sure if we are doing that but no harm |
…deep=True) for object dtype (#33157) Co-authored-by: neilkg <33635204+neilkg@users.noreply.github.com>
object
columns #33012black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
The pull request is to update lib.memory_usage_of_objects from taking self.arrays to self._values. An ASV included to benchmark with and without object-dtype columns.
Before:
After: