BUG: DatetimeIndex.astype matches Series.dtype with datetime tz dtype #33409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Apr 8, 2020
| @@ -586,7 +586,8 @@ def astype(self, dtype, copy=True): | |||
| # GH#18951: datetime64_ns dtype but not equal means different tz | |||
| new_tz = getattr(dtype, "tz", None) | |||
| if getattr(self.dtype, "tz", None) is None: | |||
| return self.tz_localize(new_tz) | |||
| # GH 33401: Match the behavior of Series.astype | |||
There was a problem hiding this comment.
is it obvious that Series is the better behavior? it might be that the only unambiguous thing to do is raise and require the user to be explicit
There was a problem hiding this comment.
That's fair. The implicit UTC localization isn't my favorite behavior.
With that in mind, should we deprecate the Series.astype(tz_dtype) UTC localization behavior instead?
|
As @jbrockmendel mentioned, this may not be the idea behavior in the first place. Going to close so we can discuss further in the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff