DEPR: deprecate non keyword arguments in read_excel #34418
Conversation
topper-123
changed the title
| @@ -33,7 +33,7 @@ def test_read_writer_table(): | |||
| columns=["Column 1", "Unnamed: 2", "Column 3"], | |||
| ) | |||
|
|
|||
| result = pd.read_excel("writertable.odt", "Table1", index_col=0) | |||
| result = pd.read_excel("writertable.odt", sheet_name="Table1", index_col=0) | |||
There was a problem hiding this comment.
Is sheet_name required to be passed like this or still OK positionally? I assume the latter from allowed_args being 2 but maybe am misreading
+/- 0 on making this required as a keyword argument. It would seem a rather natural positional argument so maybe not worth the churn, but not a strong opinion
There was a problem hiding this comment.
Is sheet_name required to be passed like this or still OK positionally?
This is just a cleanup, I think it's more readable with keyword arguments.
I think exel files are very well known, so people will easily infer that the second parameter is the sheet name, and making positional argument for sheet_name fail, e.g. in jupyter notebook could maybe be seen as too restrictive. This is not a strong opinion, so if making it a required kwarg is seen as better, I can do that.
topper-123
added
IO Excel
|
Great PR @topper-123 |
Follow-up to #27573.
Allows two non-keyword arguments,
ioandsheet_name. I thinksheet_nameis quite often (e.g. Interactively) supplied without being a keyword argument and requiring it will just be needlessly annoying.Also some clean-up in pandas/tests/io/excel.