Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: support index=True/False keyword for io.sql.get_schema #35063

Closed
wants to merge 40 commits into from
Closed

ENH: support index=True/False keyword for io.sql.get_schema #35063

wants to merge 40 commits into from

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Jun 30, 2020 •
edited
Loading

@alimcmaster1 alimcmaster1 added IO SQL to_sql, read_sql, read_sql_query Enhancement labels Jun 30, 2020
jreback
jreback requested changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can you add a whatsnew note in Other Enhancements for 1.1.

get_schema is meant to be user-facing?

@fangchenli fangchenli requested a review from jreback July 4, 2020 13:45
TomAugspurger
TomAugspurger reviewed Jul 6, 2020
View reviewed changes
pandas/io/sql.py Outdated Show resolved Hide resolved
doc/source/whatsnew/v1.1.0.rst Outdated Show resolved Hide resolved
@TomAugspurger
Copy link
Contributor

Sorry, a couple issues with the docstring: https://github.com/pandas-dev/pandas/pull/35063/checks?check_run_id=842449220#step:10:9. Do you have time to fix those here? python scripts/validate_docstring.py pandas.io.sql.get_schema should print all the issues.

@jorisvandenbossche jorisvandenbossche changed the title Sql get schema index ENH: support index=True/False keyword for io.sql.get_schema Jul 6, 2020
@jorisvandenbossche
Copy link
Member

get_schema is meant to be user-facing?

That's not entirely clear, see #9960

@dsaxton
Copy link
Member

dsaxton commented Sep 16, 2020

@VirosaLi From the above looks like this might be ready to go? Maybe merge master again?

@dsaxton dsaxton mentioned this pull request Sep 16, 2020
Merged
@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Nov 14, 2020
@fangchenli fangchenli removed the Stale label Nov 17, 2020
@pep8speaks
Copy link

pep8speaks commented Dec 8, 2020 •
edited
Loading

Hello @fangchenli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-12-08 04:46:02 UTC

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2021

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Jan 8, 2021
@alimcmaster1
Copy link
Member

@fangchenli - still interested in working on this or shall we close?

@jreback
Copy link
Contributor

jreback commented Feb 11, 2021

closing as stale. if you want to continue, pls ping and can re-open.

@jreback jreback closed this Feb 11, 2021
@fangchenli fangchenli deleted the sql-get_schema-index branch November 18, 2022 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsaxton dsaxton dsaxton left review comments

@TomAugspurger TomAugspurger TomAugspurger approved these changes

@jorisvandenbossche jorisvandenbossche Awaiting requested review from jorisvandenbossche

@jreback jreback Awaiting requested review from jreback

Assignees
No one assigned
Labels
Enhancement IO SQL to_sql, read_sql, read_sql_query Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENH: support index=True for SQL io.sql.get_schema
7 participants
@fangchenli @TomAugspurger @jorisvandenbossche @dsaxton @pep8speaks @alimcmaster1 @jreback